Skip to content

[Clang] Deleting an incomplete enum type is not an error #118455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[Clang] Deleting an incomplete enum type is not an error #118455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b89f6a
[Clang] Deleting an incomplete enum type is not an error
cor3ntin Dec 3, 2024
eeaa306
remove warning
cor3ntin Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,7 @@ Bug Fixes to C++ Support
- Fixed an assertion failure caused by mangled names with invalid identifiers. (#GH112205)
- Fixed an incorrect lambda scope of generic lambdas that caused Clang to crash when computing potential lambda
captures at the end of a full expression. (#GH115931)
- Clang no longer rejects deleting a pointer of incomplete enumeration type. (#GH99278)
Copy link
Collaborator

@erichkeane erichkeane Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer this mentions the CWG issue perhaps? Or at least a touch of backstory?

Copy link
Contributor Author

@cor3ntin cor3ntin Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CWG issue is NAD - the back story is just "regression"


Bug Fixes to AST Handling
^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
3 changes: 2 additions & 1 deletion clang/lib/Sema/SemaExprCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3748,7 +3748,8 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
// FIXME: This can result in errors if the definition was imported from a
// module but is hidden.
if (!RequireCompleteType(StartLoc, Pointee,
LangOpts.CPlusPlus26
Pointee->isStructureOrClassType() &&
LangOpts.CPlusPlus26
? diag::err_delete_incomplete
: diag::warn_delete_incomplete,
Ex.get())) {
Expand Down
8 changes: 8 additions & 0 deletions clang/test/SemaCXX/new-delete.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,14 @@ namespace PR10504 {
void f(A *x) { delete x; } // expected-warning {{delete called on 'PR10504::A' that is abstract but has non-virtual destructor}}
}

#if __cplusplus >= 201103L
enum GH99278_1 { // expected-note {{definition of 'GH99278_1' is not complete until the closing '}'}}
zero = decltype(delete static_cast<GH99278_1*>(nullptr), 0){}
// expected-warning@-1 {{deleting pointer to incomplete type}}
// expected-warning@-2 {{expression with side effects has no effect in an unevaluated context}}
};
#endif

struct PlacementArg {};
inline void *operator new[](size_t, const PlacementArg &) throw () {
return 0;
Expand Down
Loading