Skip to content

Conversation

@optimisan
Copy link
Contributor

@optimisan optimisan commented Dec 3, 2024

Use the buffered stream for printing analysis info in the pipeline.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@optimisan optimisan marked this pull request as ready for review December 3, 2024 11:20
@optimisan optimisan requested review from arsenm and cdevadas December 3, 2024 11:22
Copy link
Contributor

@paperchalice paperchalice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact I see llvm::errs() is also unbuffered:

// Set standard error to be unbuffered.
#ifdef __MVS__
std::error_code EC = enablezOSAutoConversion(STDERR_FILENO);
assert(!EC);
#endif
static raw_fd_ostream S(STDERR_FILENO, false, true);

But +1 for this, because dbg() should be used in debug context and is no different with errs() in release build.

@optimisan optimisan merged commit 92ed7e2 into main Dec 4, 2024
12 checks passed
@optimisan optimisan deleted the users/Akshat-Oke/12-03-_codegen_pm_use_errs_instead_of_dbgs_in_printer_passes branch December 4, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants