[LLVM][Maintainers] Update LLVM maintainers for OpenMP runtime #118521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm a bit surprised by the merge without approval here. Usually this kind of change needs an approval from the new maintainers, as well as the old one (unless they're no longer reachable/active) -- was this change discussed somewhere other than this PR maybe? |
Contributor
Author
|
@nikic I tried to add reviewers but it didn't let me add. Also, I wasn't able to add any comment in either of the PRs. The PR didn't show that it needed approval. It seems the issue got fixed today. I apologize for the confusion. I got approval from the new maintainers and the old maintainer is not reachable anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.