-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Add new tool: clang-read-diagnostics #118522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yuxuanchen1997
wants to merge
12
commits into
main
from
users/yuxuanchen1997/clang-read-diagnostics-tool
+153
−0
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5860f5f
start working on the new tool
yuxuanchen1997 daeadab
add to CMakeLists.txt
yuxuanchen1997 6a8bcb1
implement reading filenames, etc
yuxuanchen1997 b7e0190
format
yuxuanchen1997 e045e2d
remove includes, deps, and flags may be empty
yuxuanchen1997 93b7a06
git clang-format main
yuxuanchen1997 67d8084
incorporate feedback
yuxuanchen1997 ceee5d1
add filecheck test
yuxuanchen1997 93d8ead
Update clang-tools-extra/test/clang-read-diagnostics/error_and_warning.c
yuxuanchen1997 56496d4
add dependencies for tests
yuxuanchen1997 a0d57da
require clang to be available for the test
yuxuanchen1997 8af9416
use %t for temporary files
yuxuanchen1997 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| add_clang_tool(clang-read-diagnostics | ||
| ClangReadDiagnostics.cpp | ||
| ) | ||
|
|
||
| clang_target_link_libraries(clang-read-diagnostics | ||
| PRIVATE | ||
| clangFrontend | ||
| ) |
129 changes: 129 additions & 0 deletions
129
clang-tools-extra/clang-read-diagnostics/ClangReadDiagnostics.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| //===---- ClangReadDiagnostics.cpp - clang-read-diagnostics tool ----------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This tool is for reading clang diagnostics files from -serialize-diagnostics. | ||
| // | ||
| // Example usage: | ||
| // | ||
| // $ clang -serialize-diagnostics foo.c.diag foo.c | ||
| // $ clang-read-diagnostics foo.c.diag | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "clang/Frontend/SerializedDiagnosticReader.h" | ||
| #include "llvm/ADT/DenseMap.h" | ||
| #include "llvm/Support/CommandLine.h" | ||
| #include "llvm/Support/Signals.h" | ||
|
|
||
| #include <string> | ||
|
|
||
| using namespace clang; | ||
| using namespace clang::serialized_diags; | ||
| using namespace llvm; | ||
|
|
||
| static cl::list<std::string> InputFiles(cl::Sink, cl::desc("<input files...>"), | ||
| cl::Required); | ||
|
|
||
| class BasicSerializedDiagnosticReader : public SerializedDiagnosticReader { | ||
| public: | ||
| struct DecodedDiagnostics { | ||
| unsigned Severity; | ||
| StringRef Filename; | ||
| unsigned Line; | ||
| unsigned Col; | ||
| StringRef Category; | ||
| StringRef Flag; | ||
| StringRef Message; | ||
| }; | ||
|
|
||
| SmallVector<DecodedDiagnostics> getDiagnostics() { | ||
| SmallVector<DecodedDiagnostics> Ret; | ||
| for (const auto &Diag : Diagnostics_) { | ||
| auto Filename = FilenameIdx_.at(Diag.Location.FileID); | ||
| auto Category = CategoryIdx_.at(Diag.Category); | ||
| auto Flag = Diag.Flag == 0 ? "" : FlagIdx_.at(Diag.Flag); | ||
| Ret.emplace_back(DecodedDiagnostics{Diag.Severity, Filename, | ||
| Diag.Location.Line, Diag.Location.Col, | ||
| Category, Flag, Diag.Message}); | ||
| } | ||
| return Ret; | ||
| } | ||
|
|
||
| void dump() { | ||
| for (const auto &Diag : getDiagnostics()) { | ||
| llvm::dbgs() << Diag.Filename << ":" << Diag.Line << ":" << Diag.Col | ||
| << ": " << Diag.Message << " [category=\'" << Diag.Category | ||
| << "'"; | ||
|
|
||
| if (!Diag.Flag.empty()) | ||
| llvm::dbgs() << ", flag=" << Diag.Flag; | ||
|
|
||
| llvm::dbgs() << "]" << "\n"; | ||
| } | ||
| } | ||
|
|
||
| protected: | ||
| virtual std::error_code visitCategoryRecord(unsigned ID, | ||
| StringRef Name) override { | ||
| const auto &[_, Inserted] = CategoryIdx_.try_emplace(ID, Name); | ||
| assert(Inserted && "duplicate IDs"); | ||
| return {}; | ||
| } | ||
|
|
||
| virtual std::error_code visitDiagFlagRecord(unsigned ID, | ||
| StringRef Name) override { | ||
| const auto &[_, Inserted] = FlagIdx_.try_emplace(ID, Name); | ||
| assert(Inserted && "duplicate IDs"); | ||
| return {}; | ||
| } | ||
|
|
||
| virtual std::error_code visitFilenameRecord(unsigned ID, unsigned Size, | ||
| unsigned Timestamp, | ||
| StringRef Name) override { | ||
| const auto &[_, Inserted] = FilenameIdx_.try_emplace(ID, Name); | ||
| assert(Inserted && "duplicate IDs"); | ||
| return {}; | ||
| } | ||
|
|
||
| virtual std::error_code visitDiagnosticRecord(unsigned Severity, | ||
| const Location &Location, | ||
| unsigned Category, | ||
| unsigned Flag, | ||
| StringRef Message) override { | ||
| Diagnostics_.emplace_back( | ||
| RawDiagnostic{Severity, Location, Category, Flag, Message}); | ||
| return {}; | ||
| } | ||
|
|
||
| private: | ||
| struct RawDiagnostic { | ||
| unsigned Severity; | ||
| Location Location; | ||
| unsigned Category; | ||
| unsigned Flag; | ||
| StringRef Message; | ||
| }; | ||
|
|
||
| DenseMap<unsigned, StringRef> CategoryIdx_; | ||
| DenseMap<unsigned, StringRef> FlagIdx_; | ||
| DenseMap<unsigned, StringRef> FilenameIdx_; | ||
| std::vector<RawDiagnostic> Diagnostics_; | ||
| }; | ||
|
|
||
| int main(int argc, const char **argv) { | ||
| cl::ParseCommandLineOptions(argc, argv); | ||
| llvm::sys::PrintStackTraceOnErrorSignal(argv[0]); | ||
|
|
||
| for (const auto &File : InputFiles) { | ||
| BasicSerializedDiagnosticReader BSDR{}; | ||
| BSDR.readDiagnostics(File); | ||
| BSDR.dump(); | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
clang-tools-extra/test/clang-read-diagnostics/error_and_warning.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // REQUIRES: clang | ||
| // RUN: not %clang %s -serialize-diagnostics %t | ||
| // RUN: clang-read-diagnostics %t 2>&1 | FileCheck %s | ||
|
|
||
| #include <stdio.h> | ||
|
|
||
| int forgot_return() { | ||
| // CHECK: error_and_warning.c:9:1: non-void function does not return a value [category='Semantic Issue', flag=return-type] | ||
| } | ||
|
|
||
| int main() { | ||
| // CHECK: error_and_warning.c:13:25: expected ';' after expression [category='Parse Issue'] | ||
| printf("Hello world!") | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.