Skip to content

[Clang] Fix typo in ItaniumRecordLayoutBuilder API #118563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[Clang] Fix typo in ItaniumRecordLayoutBuilder API #118563

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d723fa
[Clang] Fix typo in ItaniumRecordLayoutBuilder API
Ptkyr Dec 4, 2024
f453dcd
Merge branch 'main' into main
Ptkyr Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/AST/RecordLayoutBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ class ItaniumRecordLayoutBuilder {
void setSize(CharUnits NewSize) { Size = Context.toBits(NewSize); }
void setSize(uint64_t NewSize) { Size = NewSize; }

CharUnits getAligment() const { return Alignment; }
CharUnits getAlignment() const { return Alignment; }
Copy link
Contributor

@cor3ntin cor3ntin Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that used at all then?

Copy link
Contributor

@zyn0217 zyn0217 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like an internal class so I think the answer is no

Copy link
Contributor Author

@Ptkyr Ptkyr Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just something I happened to notice when debugging something else. Not sure how well-received tiny prs like these are, but figured it was worth pointing out.


CharUnits getDataSize() const {
assert(DataSize % Context.getCharWidth() == 0);
Expand Down
Loading