Skip to content

Conversation

@nickdesaulniers
Copy link
Member

@nickdesaulniers
Copy link
Member Author

@SchrodingerZhu if you have a windows build handy, can you please help test this out? This would be doing a fullbuild on windows.

@llvmbot
Copy link
Member

llvmbot commented Dec 4, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes

Link: #117220 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/118675.diff

1 Files Affected:

  • (added) libc/config/windows/headers.txt (+32)
diff --git a/libc/config/windows/headers.txt b/libc/config/windows/headers.txt
new file mode 100644
index 00000000000000..d5b44fc07277e5
--- /dev/null
+++ b/libc/config/windows/headers.txt
@@ -0,0 +1,32 @@
+set(TARGET_PUBLIC_HEADERS
+    libc.include.assert
+    libc.include.ctype
+    libc.include.dirent
+    libc.include.errno
+    libc.include.features
+    libc.include.fenv
+    libc.include.float
+    libc.include.inttypes
+    libc.include.limits
+    libc.include.link
+    libc.include.locale
+    libc.include.malloc
+    libc.include.math
+    libc.include.sched
+    libc.include.search
+    libc.include.setjmp
+    libc.include.signal
+    libc.include.stdbit
+    libc.include.stdckdint
+    libc.include.stdfix
+    libc.include.stdint
+    libc.include.stdio
+    libc.include.stdlib
+    libc.include.string
+    libc.include.strings
+    libc.include.threads
+    libc.include.time
+    libc.include.uchar
+    libc.include.unistd
+    libc.include.wchar
+)

@SchrodingerZhu
Copy link
Contributor

SchrodingerZhu commented Dec 4, 2024

@SchrodingerZhu if you have a windows build handy, can you please help test this out? This would be doing a fullbuild on windows.

trying out now on windows server 2025.

@SchrodingerZhu
Copy link
Contributor

No issue found running ninja check-libc

@ilovepi
Copy link
Contributor

ilovepi commented Dec 4, 2024

@nickdesaulniers nickdesaulniers merged commit 5e769fb into llvm:main Dec 4, 2024
5 of 6 checks passed
@nickdesaulniers nickdesaulniers deleted the windows_headers branch December 4, 2024 20:38
@nickdesaulniers
Copy link
Member Author

I also kicked off https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-windows-x64/b8729459123378281649/overview with this patch.

Looks like that passed to me, but its also my first time looking at that such dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants