Skip to content

[IVDescriptors] Call getOpcode on demand in getReductionOpChain. nfc #118777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

[IVDescriptors] Call getOpcode on demand in getReductionOpChain. nfc #118777

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c458e9e
[IVDescriptors][NFC] Refactor getReductionOpChain to remove the depen…
Mel-Chen Dec 5, 2024
137c6c4
Rebase, and remove isArithmeticRecurrenceKind
Mel-Chen Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions llvm/lib/Analysis/IVDescriptors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,6 @@ unsigned RecurrenceDescriptor::getOpcode(RecurKind Kind) {
SmallVector<Instruction *, 4>
RecurrenceDescriptor::getReductionOpChain(PHINode *Phi, Loop *L) const {
SmallVector<Instruction *, 4> ReductionOperations;
unsigned RedOp = getOpcode();
const bool IsMinMax = isMinMaxRecurrenceKind(Kind);

// Search down from the Phi to the LoopExitInstr, looking for instructions
Expand Down Expand Up @@ -1237,7 +1236,7 @@ RecurrenceDescriptor::getReductionOpChain(PHINode *Phi, Loop *L) const {
if (isFMulAddIntrinsic(Cur))
return true;

return Cur->getOpcode() == RedOp;
return Cur->getOpcode() == getOpcode();
Comment on lines -1240 to +1239
Copy link
Contributor

@artagnon artagnon Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're checking for opcode here anyway.

Copy link
Contributor Author

@Mel-Chen Mel-Chen Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only arithmetic reductions call getOpcode and check the opcode, non-arithmetic won't reach this check statement.

};

// Attempt to look through Phis which are part of the reduction chain
Expand Down