[MLIR][StaticValueUtils] Fold constant SSA values + fix isRankReduced #118971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Ops with dynamic/static offsets/sizes/strides that make use of `dispatchIndexOpFoldResult` API shouldn't can afford to fold away any constant SSA values. This commit adds a fix to the same. -- Consequently it adds a fix to `isRankReducedType` as well as `computeRankReductionMask`. Signed-off-by: Abhishek Varma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Ops with dynamic/static offsets/sizes/strides that make use of
dispatchIndexOpFoldResultAPI shouldn't can afford to fold awayany constant SSA values. This commit adds a fix to the same.
-- Consequently it adds a fix to
isRankReducedTypeas well ascomputeRankReductionMask.Signed-off-by: Abhishek Varma [email protected]