[libc++] Make a few test helper constructors explicit

[ldionne]

No description provided.

[ldionne]

CC @winner245

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/118975.diff

1 Files Affected:

• (modified) libcxx/test/std/containers/sequences/vector/common.h (+2-2)

diff --git a/libcxx/test/std/containers/sequences/vector/common.h b/libcxx/test/std/containers/sequences/vector/common.h
index cd57b6cc3e7235..ff8147ef6b838b 100644
--- a/libcxx/test/std/containers/sequences/vector/common.h
+++ b/libcxx/test/std/containers/sequences/vector/common.h
@@ -20,7 +20,7 @@ struct throwing_t {
   int* throw_after_n_ = nullptr;
   throwing_t() { throw 0; }
 
-  throwing_t(int& throw_after_n) : throw_after_n_(&throw_after_n) {
+  explicit throwing_t(int& throw_after_n) : throw_after_n_(&throw_after_n) {
     if (throw_after_n == 0)
       throw 0;
     --throw_after_n;
@@ -95,7 +95,7 @@ struct throwing_iterator {
   int i_;
   T v_;
 
-  throwing_iterator(int i = 0, const T& v = T()) : i_(i), v_(v) {}
+  explicit throwing_iterator(int i = 0, const T& v = T()) : i_(i), v_(v) {}
 
   reference operator*() {
     if (i_ == 1)

[winner245]

LGTM upon CI green.

[winner245]

Is the lldb test in stage3 (bootstrapping-build) broken? The failed tests seem completely unrelated to this PR (they also failed in my PR):

Failed Tests (15):
lldb-api :: commands/expression/import-std-module/basic/TestImportStdModule.py
lldb-api :: commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
lldb-api :: commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
lldb-api :: commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
lldb-api :: commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
lldb-api :: commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
lldb-api :: commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
lldb-api :: commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py
lldb-api :: commands/expression/import-std-module/list/TestListFromStdModule.py
lldb-api :: commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
lldb-api :: commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
lldb-api :: commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
lldb-api :: commands/expression/import-std-module/shared_ptr/TestSharedPtrFromStdModule.py
lldb-api :: commands/expression/import-std-module/weak_ptr-dbg-info-content/TestDbgInfoContentWeakPtrFromStdModule.py
lldb-api :: commands/expression/import-std-module/weak_ptr/TestWeakPtrFromStdModule.py

[ldionne]

Looks like this was broken recently in the bootstrapping build. This is probably caused by a clang change. I'll investigate separately.

In the meantime I think we can consider the CI to be green.