Skip to content

Conversation

@jeanPerier
Copy link
Contributor

Otherwise, builds with -DFLANG_CUF_RUNTIME hits:

runtime/CUDA/descriptor.cpp:44:24: error: invalid use of incomplete type 'const class Fortran::runtime::Descriptor'
   44 |   std::size_t count{src->SizeInBytes()};

@llvmbot llvmbot added flang:runtime flang Flang issues not falling into any other category labels Dec 6, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 6, 2024

@llvm/pr-subscribers-flang-runtime

Author: None (jeanPerier)

Changes

Otherwise, builds with -DFLANG_CUF_RUNTIME hits:

runtime/CUDA/descriptor.cpp:44:24: error: invalid use of incomplete type 'const class Fortran::runtime::Descriptor'
   44 |   std::size_t count{src->SizeInBytes()};

Full diff: https://github.com/llvm/llvm-project/pull/118993.diff

1 Files Affected:

  • (modified) flang/runtime/CUDA/descriptor.cpp (+1)
diff --git a/flang/runtime/CUDA/descriptor.cpp b/flang/runtime/CUDA/descriptor.cpp
index f1feb00941aa8a..a42ccea3176051 100644
--- a/flang/runtime/CUDA/descriptor.cpp
+++ b/flang/runtime/CUDA/descriptor.cpp
@@ -10,6 +10,7 @@
 #include "../terminator.h"
 #include "flang/Runtime/CUDA/allocator.h"
 #include "flang/Runtime/CUDA/common.h"
+#include "flang/Runtime/descriptor.h"
 
 #include "cuda_runtime.h"
 

Copy link
Contributor

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jean!

@jeanPerier jeanPerier merged commit d6ec7c8 into llvm:main Dec 6, 2024
8 of 10 checks passed
@jeanPerier jeanPerier deleted the fix-cuf-rt branch December 6, 2024 16:22
@Meinersbur
Copy link
Member

Sorry about this mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:runtime flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants