[lldb] Fix off by one in array index check in Objective C runtime plugin #118995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSpickett
changed the title
DavidSpickett
changed the title
Member
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesReported in #116944 / https://pvs-studio.com/en/blog/posts/cpp/1188/. Full diff: https://github.com/llvm/llvm-project/pull/118995.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
index 0083b499656979..c43871b08191db 100644
--- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -3278,7 +3278,7 @@ bool AppleObjCRuntimeV2::NonPointerISACache::EvaluateNonPointerISA(
}
// If the index is still out of range then this isn't a pointer.
- if (index > m_indexed_isa_cache.size())
+ if (index >= m_indexed_isa_cache.size())
return false;
LLDB_LOGF(log, "AOCRT::NPI Evaluate(ret_isa = 0x%" PRIx64 ")",
|
Collaborator
Author
|
Seems obvious but perhaps Apple folks can confirm that there isn't some hidden detail here, or a larger mistake hiding in the background. |
JDevlieghere
approved these changes
Dec 6, 2024
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Dec 6, 2024
…gin (llvm#118995) Reported in llvm#116944 / https://pvs-studio.com/en/blog/posts/cpp/1188/. (cherry picked from commit a46ee73)
adrian-prantl
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 9, 2024
…-6.1-lldb-Fix-off-by-one-in-array-index-check-in-Objective-C-runtime-plugin-118995 [Cherry-pick into swift/release/6.1] [lldb] Fix off by one in array index check in Objective C runtime plugin (llvm#118995)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #116944 / https://pvs-studio.com/en/blog/posts/cpp/1188/.