Skip to content

[memprof] Use IndexedMemProfData in a unit test (NFC) #119062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2024
Merged

[memprof] Use IndexedMemProfData in a unit test (NFC) #119062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions llvm/unittests/ProfileData/MemProfTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,12 +549,6 @@ TEST(MemProf, IndexedMemProfRecordToMemProfRecord) {
EXPECT_EQ(Record.CallSites[1][1].hash(), F4.hash());
}

using FrameIdMapTy =
llvm::DenseMap<::llvm::memprof::FrameId, ::llvm::memprof::Frame>;
using CallStackIdMapTy =
llvm::DenseMap<::llvm::memprof::CallStackId,
::llvm::SmallVector<::llvm::memprof::FrameId>>;

// Populate those fields returned by getHotColdSchema.
MemInfoBlock makePartialMIB() {
MemInfoBlock MIB;
Expand All @@ -575,12 +569,11 @@ TEST(MemProf, MissingCallStackId) {
IndexedMR.AllocSites.push_back(AI);

// Create empty maps.
const FrameIdMapTy IdToFrameMap;
const CallStackIdMapTy CSIdToCallStackMap;
llvm::memprof::FrameIdConverter<decltype(IdToFrameMap)> FrameIdConv(
IdToFrameMap);
llvm::memprof::CallStackIdConverter<decltype(CSIdToCallStackMap)> CSIdConv(
CSIdToCallStackMap, FrameIdConv);
IndexedMemProfData MemProfData;
llvm::memprof::FrameIdConverter<decltype(MemProfData.Frames)> FrameIdConv(
MemProfData.Frames);
llvm::memprof::CallStackIdConverter<decltype(MemProfData.CallStacks)>
CSIdConv(MemProfData.CallStacks, FrameIdConv);

// We are only interested in errors, not the return value.
(void)IndexedMR.toMemProfRecord(CSIdConv);
Expand All @@ -597,15 +590,14 @@ TEST(MemProf, MissingFrameId) {
IndexedMemProfRecord IndexedMR;
IndexedMR.AllocSites.push_back(AI);

// An empty map to trigger a mapping error.
const FrameIdMapTy IdToFrameMap;
CallStackIdMapTy CSIdToCallStackMap;
CSIdToCallStackMap.insert({0x222, {2, 3}});
// An empty Frame map to trigger a mapping error.
IndexedMemProfData MemProfData;
MemProfData.CallStacks.insert({0x222, {2, 3}});

llvm::memprof::FrameIdConverter<decltype(IdToFrameMap)> FrameIdConv(
IdToFrameMap);
llvm::memprof::CallStackIdConverter<decltype(CSIdToCallStackMap)> CSIdConv(
CSIdToCallStackMap, FrameIdConv);
llvm::memprof::FrameIdConverter<decltype(MemProfData.Frames)> FrameIdConv(
MemProfData.Frames);
llvm::memprof::CallStackIdConverter<decltype(MemProfData.CallStacks)>
CSIdConv(MemProfData.CallStacks, FrameIdConv);

// We are only interested in errors, not the return value.
(void)IndexedMR.toMemProfRecord(CSIdConv);
Expand Down
Loading