[Clang] Fix wrong call location of DefaultArgExpr.

[16bit-ykiko]

Fix #119129.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clang-tidy

@llvm/pr-subscribers-clang

Author: ykiko (16bit-ykiko)

Changes

Fix #119129.

---

Full diff: https://github.com/llvm/llvm-project/pull/119212.diff

1 Files Affected:

• (modified) clang/lib/Sema/SemaExpr.cpp (+1-1)

diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index 14564b99de44c5..9b543d6484b85c 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -5948,7 +5948,7 @@ Sema::ConvertArgumentsForCall(CallExpr *Call, Expr *Fn,
   SmallVector<Expr *, 8> AllArgs;
   VariadicCallType CallType = getVariadicCallType(FDecl, Proto, Fn);
 
-  Invalid = GatherArgumentsForCall(Call->getBeginLoc(), FDecl, Proto, 0, Args,
+  Invalid = GatherArgumentsForCall(Call->getExprLoc(), FDecl, Proto, 0, Args,
                                    AllArgs, CallType);
   if (Invalid)
     return true;

[cor3ntin]

This looks reasonable but needs tests (you could adapt #119129 to to make foo a constexpr function returning the line number, and checking that. use #line 4242 to make the test less susceptible to lines changes.

A changelog entry would be useful too

[cor3ntin]

LGTM modulo nit