Skip to content

UncountedLocalVarsChecker and UncheckedLocalVarsChecker should recognize signletons. #119339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

UncountedLocalVarsChecker and UncheckedLocalVarsChecker should recognize signletons. #119339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ class RawPtrRefLocalVarsChecker
if (tryToFindPtrOrigin(
Value, /*StopAtFirstRefCountedObj=*/false,
[&](const clang::Expr *InitArgOrigin, bool IsSafe) {
if (!InitArgOrigin)
if (!InitArgOrigin || IsSafe)
return true;

if (isa<CXXThisExpr>(InitArgOrigin))
Expand Down
9 changes: 9 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/uncounted-local-vars.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,3 +456,12 @@ int TreeNode::recursiveWeight() {
}

} // namespace local_var_in_recursive_function

namespace local_var_for_singleton {
RefCountable *singleton();
RefCountable *otherSingleton();
void foo() {
RefCountable* bar = singleton();
RefCountable* baz = otherSingleton();
}
}
Loading