Skip to content

[Clang] Don't check incomplete CXXRecordDecl's members when transforming sizeof...(expr) #119344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[Clang] Don't check incomplete CXXRecordDecl's members when transforming sizeof...(expr) #119344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bca3cea
[Clang] Don't check incomplete CXXRecordDecl's members when transform…
zyn0217 Dec 10, 2024
41c1c6a
Address review feedback
zyn0217 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,7 @@ Bug Fixes to C++ Support
- Fixed an assertion failure caused by using ``consteval`` in condition in consumed analyses. (#GH117385)
- Fix a crash caused by incorrect argument position in merging deduced template arguments. (#GH113659)
- Fixed a parser crash when using pack indexing as a nested name specifier. (#GH119072)
- Fixed a null pointer dereference issue when heuristically computing ``sizeof...(pack)`` expressions. (#GH81436)
- Fixed an assertion failure caused by mangled names with invalid identifiers. (#GH112205)
- Fixed an incorrect lambda scope of generic lambdas that caused Clang to crash when computing potential lambda
captures at the end of a full expression. (#GH115931)
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Sema/SemaExpr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19297,7 +19297,7 @@ static ExprResult rebuildPotentialResultsAsNonOdrUsed(Sema &S, Expr *E,
if (VD->getType()->isReferenceType())
return true;
if (auto *RD = VD->getType()->getAsCXXRecordDecl())
if (RD->hasMutableFields())
if (RD->hasDefinition() && RD->hasMutableFields())
return true;
if (!VD->isUsableInConstantExpressions(S.Context))
return true;
Expand Down
22 changes: 22 additions & 0 deletions clang/test/CXX/temp/temp.decls/temp.variadic/sizeofpack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s
// expected-no-diagnostics

namespace pr12262 {
Expand Down Expand Up @@ -201,3 +202,24 @@ void func()
}

}

#if __cplusplus >= 202002L
namespace GH81436 {

template <class E> struct Bar;

template <class E>
Bar(E) -> Bar<E>;

template <int> struct Foo {};

// Bar<Ts> doesn't have to be of a complete type.
template <class... Ts>
auto func() requires requires(Bar<Ts> ...init_lists) {
sizeof...(init_lists) > 0;
} {}

void f() { func<int>(); }

} // namespace GH81436
#endif
Loading