Skip to content

[flang][cuda] Fix lowering when step is a variable #119421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[flang][cuda] Fix lowering when step is a variable #119421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions flang/lib/Lower/Bridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3037,8 +3037,10 @@ class FirConverter : public Fortran::lower::AbstractConverter {
fir::getBase(genExprValue(*Fortran::semantics::GetExpr(bounds->upper),
stmtCtx))));
if (bounds->step)
steps.push_back(fir::getBase(
genExprValue(*Fortran::semantics::GetExpr(bounds->step), stmtCtx)));
steps.push_back(builder->createConvert(
crtLoc, idxTy,
fir::getBase(genExprValue(
*Fortran::semantics::GetExpr(bounds->step), stmtCtx))));
else // If `step` is not present, assume it is `1`.
steps.push_back(builder->createIntegerConstant(loc, idxTy, 1));

Expand Down
15 changes: 15 additions & 0 deletions flang/test/Lower/CUDA/cuda-kernel-loop-directive.cuf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,18 @@ end subroutine

! CHECK-LABEL: func.func @_QPsub2
! CHECK: cuf.kernel

subroutine sub3()
integer, device :: a(10), b(10)
integer :: lb = 1
integer :: n = 10
integer :: s = 1

!$cuf kernel do <<< *, * >>>
do i = lb, n, s
a(i) = a(i) * b(i)
end do
end

! CHECK-LABEL: func.func @_QPsub3
! CHECK: cuf.kernel
Loading