Skip to content

[bazel] Fix lit tests with bazel 8.x #119462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

[bazel] Fix lit tests with bazel 8.x #119462

merged 1 commit into from
Dec 10, 2024

Conversation

@keith
Copy link
Member

@keith keith commented Dec 10, 2024

@keith keith requested a review from rupprecht as a code owner December 10, 2024 22:08
@keith keith mentioned this pull request Dec 10, 2024
Merged
@keith keith merged commit bedbaff into llvm:main Dec 10, 2024
5 of 7 checks passed
@keith keith deleted the ks/bazel-fix-lit-tests-with-bazel-8.x branch December 10, 2024 22:09
@keith keith mentioned this pull request Dec 10, 2024
Open
@nickdesaulniers
Copy link
Member

nickdesaulniers commented Dec 10, 2024

Ah, legacy_external_runfiles is mentioned briefly in https://github.com/bazelbuild/bazel/releases/tag/8.0.0.

Thanks for bisecting bazel to find what changed, and submit the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rupprecht rupprecht Awaiting requested review from rupprecht rupprecht is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keith @nickdesaulniers