Skip to content

[libclc] Optimize ceil/fabs/floor/rint/trunc #119596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

[libclc] Optimize ceil/fabs/floor/rint/trunc #119596

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68df262
[libclc] Optimize ceil/fabs/floor/rint/trunc
frasercrmck Dec 11, 2024
c825dc0
move away from using intrinsics
frasercrmck Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion libclc/clc/include/clc/clcmacro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,21 @@

#define _CLC_DEFINE_UNARY_BUILTIN(RET_TYPE, FUNCTION, BUILTIN, ARG1_TYPE) \
_CLC_DEF _CLC_OVERLOAD RET_TYPE FUNCTION(ARG1_TYPE x) { return BUILTIN(x); } \
_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, RET_TYPE, FUNCTION, ARG1_TYPE)
_CLC_DEF _CLC_OVERLOAD RET_TYPE##2 FUNCTION(ARG1_TYPE##2 x) { \
return BUILTIN(x); \
} \
_CLC_DEF _CLC_OVERLOAD RET_TYPE##3 FUNCTION(ARG1_TYPE##3 x) { \
return BUILTIN(x); \
} \
_CLC_DEF _CLC_OVERLOAD RET_TYPE##4 FUNCTION(ARG1_TYPE##4 x) { \
return BUILTIN(x); \
} \
_CLC_DEF _CLC_OVERLOAD RET_TYPE##8 FUNCTION(ARG1_TYPE##8 x) { \
return BUILTIN(x); \
} \
_CLC_DEF _CLC_OVERLOAD RET_TYPE##16 FUNCTION(ARG1_TYPE##16 x) { \
return BUILTIN(x); \
}

#ifdef cl_khr_fp16

Expand Down
7 changes: 0 additions & 7 deletions libclc/clc/include/clc/math/clc_ceil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
#ifndef __CLC_MATH_CLC_CEIL_H__
#define __CLC_MATH_CLC_CEIL_H__

#if defined(CLC_CLSPV) || defined(CLC_SPIRV)
// clspv and spir-v targets provide their own OpenCL-compatible ceil
#define __clc_ceil ceil
#else

// Map the function to an LLVM intrinsic
#define __CLC_FUNCTION __clc_ceil
#define __CLC_INTRINSIC "llvm.ceil"
Expand All @@ -14,6 +9,4 @@
#undef __CLC_INTRINSIC
#undef __CLC_FUNCTION

#endif

#endif // __CLC_MATH_CLC_CEIL_H__
7 changes: 0 additions & 7 deletions libclc/clc/include/clc/math/clc_fabs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
#ifndef __CLC_MATH_CLC_FABS_H__
#define __CLC_MATH_CLC_FABS_H__

#if defined(CLC_CLSPV) || defined(CLC_SPIRV)
// clspv and spir-v targets provide their own OpenCL-compatible fabs
#define __clc_fabs fabs
#else

// Map the function to an LLVM intrinsic
#define __CLC_FUNCTION __clc_fabs
#define __CLC_INTRINSIC "llvm.fabs"
Expand All @@ -14,6 +9,4 @@
#undef __CLC_INTRINSIC
#undef __CLC_FUNCTION

#endif

#endif // __CLC_MATH_CLC_FABS_H__
7 changes: 0 additions & 7 deletions libclc/clc/include/clc/math/clc_floor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
#ifndef __CLC_MATH_CLC_FLOOR_H__
#define __CLC_MATH_CLC_FLOOR_H__

#if defined(CLC_CLSPV) || defined(CLC_SPIRV)
// clspv and spir-v targets provide their own OpenCL-compatible floor
#define __clc_floor floor
#else

// Map the function to an LLVM intrinsic
#define __CLC_FUNCTION __clc_floor
#define __CLC_INTRINSIC "llvm.floor"
Expand All @@ -14,6 +9,4 @@
#undef __CLC_INTRINSIC
#undef __CLC_FUNCTION

#endif

#endif // __CLC_MATH_CLC_FLOOR_H__
7 changes: 0 additions & 7 deletions libclc/clc/include/clc/math/clc_rint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
#ifndef __CLC_MATH_CLC_RINT_H__
#define __CLC_MATH_CLC_RINT_H__

#if defined(CLC_CLSPV) || defined(CLC_SPIRV)
// clspv and spir-v targets provide their own OpenCL-compatible rint
#define __clc_rint rint
#else

// Map the function to an LLVM intrinsic
#define __CLC_FUNCTION __clc_rint
#define __CLC_INTRINSIC "llvm.rint"
Expand All @@ -14,6 +9,4 @@
#undef __CLC_INTRINSIC
#undef __CLC_FUNCTION

#endif

#endif // __CLC_MATH_CLC_RINT_H__
7 changes: 0 additions & 7 deletions libclc/clc/include/clc/math/clc_trunc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
#ifndef __CLC_MATH_CLC_TRUNC_H__
#define __CLC_MATH_CLC_TRUNC_H__

#if defined(CLC_CLSPV) || defined(CLC_SPIRV)
// clspv and spir-v targets provide their own OpenCL-compatible trunc
#define __clc_trunc trunc
#else

// Map the function to an LLVM intrinsic
#define __CLC_FUNCTION __clc_trunc
#define __CLC_INTRINSIC "llvm.trunc"
Expand All @@ -14,6 +9,4 @@
#undef __CLC_INTRINSIC
#undef __CLC_FUNCTION

#endif

#endif // __CLC_MATH_CLC_TRUNC_H__
Loading