Skip to content

[NFC] Fixes for issues found by static analysis tool. #119741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[NFC] Fixes for issues found by static analysis tool. #119741

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
440554d
[NFC] Use a move instead of a copy to optimize performance.
zahiraam Dec 4, 2024
4eaeba8
Merge remote-tracking branch 'origin/main' into CopyToMove
zahiraam Dec 12, 2024
fadfd03
[NFC] Fixed a couple issues found trhough static analysis tool.
zahiraam Dec 12, 2024
273d144
Fix format.
zahiraam Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions clang-tools-extra/clangd/ModulesBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,14 @@ class ReusablePrerequisiteModules : public PrerequisiteModules {
public:
ReusablePrerequisiteModules() = default;

ReusablePrerequisiteModules(const ReusablePrerequisiteModules &Other) =
default;
ReusablePrerequisiteModules(const ReusablePrerequisiteModules &Other)
: PrerequisiteModules(Other) {
RequiredModules = Other.RequiredModules;
BuiltModuleNames = Other.BuiltModuleNames;
}

ReusablePrerequisiteModules &
operator=(const ReusablePrerequisiteModules &) = default;
operator=(const ReusablePrerequisiteModules &) = delete;
ReusablePrerequisiteModules(ReusablePrerequisiteModules &&) = delete;
ReusablePrerequisiteModules
operator=(ReusablePrerequisiteModules &&) = delete;
Expand Down Expand Up @@ -310,7 +314,7 @@ bool ReusablePrerequisiteModules::canReuse(
llvm::SmallVector<llvm::StringRef> BMIPaths;
for (auto &MF : RequiredModules)
BMIPaths.push_back(MF->getModuleFilePath());
return IsModuleFilesUpToDate(BMIPaths, *this, VFS);
return IsModuleFilesUpToDate(std::move(BMIPaths), *this, VFS);
}

class ModuleFileCache {
Expand Down
Loading