[Assignment Tracking] Change placeholder from undef to poison
#119760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty metadata address components of `dbg.assign` can be represented as `poison` values instead of `undef` values.
Member
|
@llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-llvm-ir Author: Pedro Lobo (pedroclobo) ChangesEmpty metadata address components of Full diff: https://github.com/llvm/llvm-project/pull/119760.diff 1 Files Affected:
diff --git a/llvm/lib/IR/IntrinsicInst.cpp b/llvm/lib/IR/IntrinsicInst.cpp
index 002bab8e079e50..79795e5691f865 100644
--- a/llvm/lib/IR/IntrinsicInst.cpp
+++ b/llvm/lib/IR/IntrinsicInst.cpp
@@ -223,12 +223,12 @@ void DbgAssignIntrinsic::setAddress(Value *V) {
void DbgAssignIntrinsic::setKillAddress() {
if (isKillAddress())
return;
- setAddress(UndefValue::get(getAddress()->getType()));
+ setAddress(PoisonValue::get(getAddress()->getType()));
}
bool DbgAssignIntrinsic::isKillAddress() const {
Value *Addr = getAddress();
- return !Addr || isa<UndefValue>(Addr);
+ return !Addr || isa<PoisonValue>(Addr);
}
void DbgAssignIntrinsic::setValue(Value *V) {
|
Member
Author
|
cc @nunoplopes |
nunoplopes
reviewed
Dec 13, 2024
`undef` should continue to be used here to ensure compatibility with older IR.
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/12486 Here is the relevant piece of the build log for the reference |
Member
|
seems like a spurious failure; the build bot is green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty metadata address components of
dbg.assigncan be represented aspoisonvalues instead ofundefvalues.