[SandboxIR] Use std::make_unique (NFC) #119824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With std::make_unique, we don't have to mention the type twice. Identified with modernize-make-unique.
vporpo
pushed a commit
to vporpo/llvm-project
that referenced
this pull request
Dec 13, 2024
This patch changes the visibility of the constructors of CatchSwitchInst ResumeInst and SwitchInst to private instead of public. This is similar to all other Sandbox IR instructions. The constructor is private to force the user go through the Context create* API. The issue was exposed by: llvm#119824
Contributor
|
The reason we were using |
Contributor
Author
Thank you for the explanation! I just LGTMed #119901. |
vporpo
pushed a commit
that referenced
this pull request
Dec 13, 2024
This patch changes the visibility of the constructors of CatchSwitchInst ResumeInst and SwitchInst to private instead of public. This is similar to all other Sandbox IR instructions. The constructor is private to force the user go through the Context create* API. The issue was exposed by: #119824
Contributor
|
Thanks! I just pushed the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With std::make_unique, we don't have to mention the type twice.
Identified with modernize-make-unique.