Skip to content

[lldb][AIX] XCOFF clang-format and other minor changes #119892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 13, 2024
Merged

[lldb][AIX] XCOFF clang-format and other minor changes #119892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0c63800
Added XCOFF Header Parsing
DhruvSrivastavaX Nov 15, 2024
132418f
Added XCOFF Header Parsing
DhruvSrivastavaX Nov 15, 2024
d1ee9b8
Added XCOFF Header Parsing
DhruvSrivastavaX Nov 15, 2024
e9322c4
Using llvm XCOFF structures
DhruvSrivastavaX Nov 28, 2024
b5c0110
Adding llvm structure
DhruvSrivastavaX Nov 29, 2024
c4cf612
Added parsing functions
DhruvSrivastavaX Dec 8, 2024
2301092
Addressing comments 1
DhruvSrivastavaX Dec 11, 2024
5f6083a
Comments
DhruvSrivastavaX Dec 13, 2024
1aef260
Added clang-format changes
DhruvSrivastavaX Dec 13, 2024
675a4e1
Cleanup
DhruvSrivastavaX Dec 13, 2024
da0e55e
Cleanup
DhruvSrivastavaX Dec 13, 2024
88242f2
Cleanup
DhruvSrivastavaX Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
//===----------------------------------------------------------------------===//

#include "ObjectFileXCOFF.h"

#include <algorithm>
#include <cassert>
#include <cstring>
#include <unordered_map>

#include "lldb/Core/Module.h"
#include "lldb/Core/ModuleSpec.h"
#include "lldb/Core/PluginManager.h"
Expand All @@ -35,6 +29,10 @@
#include "llvm/BinaryFormat/XCOFF.h"
#include "llvm/Object/XCOFFObjectFile.h"
#include "llvm/Support/MemoryBuffer.h"
#include <algorithm>
#include <cassert>
#include <cstring>
#include <unordered_map>

using namespace llvm;
using namespace lldb;
Expand Down Expand Up @@ -110,10 +108,9 @@ size_t ObjectFileXCOFF::GetModuleSpecifications(

static uint32_t XCOFFHeaderSizeFromMagic(uint32_t magic) {
switch (magic) {
/* TODO: 32bit not supported yet
case XCOFF::XCOFF32:
return sizeof(struct llvm::object::XCOFFFileHeader32);
*/
// TODO: 32bit not supported yet
// case XCOFF::XCOFF32:
// return sizeof(struct llvm::object::XCOFFFileHeader32);

case XCOFF::XCOFF64:
return sizeof(struct llvm::object::XCOFFFileHeader64);
Expand Down
6 changes: 2 additions & 4 deletions lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,14 @@
#ifndef LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H
#define LLDB_SOURCE_PLUGINS_OBJECTFILE_XCOFF_OBJECTFILEXCOFF_H

#include <cstdint>

#include <vector>

#include "lldb/Symbol/ObjectFile.h"
#include "lldb/Utility/ArchSpec.h"
#include "lldb/Utility/FileSpec.h"
#include "lldb/Utility/UUID.h"
#include "lldb/lldb-private.h"
#include "llvm/Object/XCOFFObjectFile.h"
#include <cstdint>
#include <vector>

/// \class ObjectFileXCOFF
/// Generic XCOFF object file reader.
Expand Down
Loading