Skip to content

[clang][ObjectiveC] Fix Parsing the :: Optional Scope Specifier #119908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2024
Merged

[clang][ObjectiveC] Fix Parsing the :: Optional Scope Specifier #119908

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63c4244
Fix parsing :: in method parameter type.
qiongsiwu Dec 13, 2024
ec903eb
Fix ObjectiveC++
qiongsiwu Dec 16, 2024
66c3b0b
Address code review.
qiongsiwu Dec 18, 2024
2e0667d
Modifying the test to include valid Objective-C with
qiongsiwu Dec 18, 2024
f268116
Merge branch 'main' into fix_objc_coloncolon
qiongsiwu Dec 18, 2024
c3c57ac
Merge branch 'main' into fix_objc_coloncolon
qiongsiwu Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion clang/lib/Parse/Parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,8 +2222,15 @@ bool Parser::TryAnnotateTypeOrScopeTokenAfterScopeSpec(
}
}

if (SS.isEmpty())
if (SS.isEmpty()) {
if (getLangOpts().ObjC && !getLangOpts().CPlusPlus &&
Tok.is(tok::coloncolon)) {
// ObjectiveC does not allow :: as as a scope token.
Diag(ConsumeToken(), diag::err_expected_type);
return true;
}
return false;
}

// A C++ scope specifier that isn't followed by a typename.
AnnotateScopeToken(SS, IsNewScope);
Expand Down
5 changes: 5 additions & 0 deletions clang/test/Parser/objc-coloncolon.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// RUN: %clang_cc1 -x objective-c -fsyntax-only -verify %s

@interface A
- (instancetype)init:(::A *) foo; // expected-error {{expected a type}}
@end
Loading