Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/include/llvm/BinaryFormat/ELF.h
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,9 @@ enum : unsigned {
// ELF Relocation types for RISC-V
enum {
#include "ELFRelocs/RISCV.def"
#define ELF_RISCV_NONSTANDARD_RELOC(_vendor, name, value) name = value,
#include "ELFRelocs/RISCV_nonstandard.def"
#undef ELF_RISCV_NONSTANDARD_RELOC
};

enum {
Expand Down
30 changes: 30 additions & 0 deletions llvm/include/llvm/BinaryFormat/ELFRelocs/RISCV_nonstandard.def
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
//===--- RISC-V Nonstandard Relocation List ---------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef ELF_RISCV_NONSTANDARD_RELOC
#error "ELF_RISCV_NONSTANDARD_RELOC must be defined"
#endif

/*
ELF_RISCV_NONSTANDARD_RELOC(VENDOR, NAME, ID) defines information about
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer //

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

nonstandard relocation codes. This can be used when parsing relocations, or
when printing them, to provide better information.
VENDOR should be the symbol name expected in the associated `R_RISCV_VENDOR`
relocation. NAME and ID work like `ELF_RELOC` but the mapping is not expected
to be 1:1.
The mapping in RISCV.def is 1:1, and should be used when the only information
available is the relocation enum value.
*/

/* Qualcomm Nonstandard Relocations */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ELF_RISCV_NONSTANDARD_RELOC(QUALCOMM, R_RISCV_QC_ABS20_U, 192)
ELF_RISCV_NONSTANDARD_RELOC(QUALCOMM, R_RISCV_QC_E_BRANCH, 193)
ELF_RISCV_NONSTANDARD_RELOC(QUALCOMM, R_RISCV_QC_E_32, 194)
ELF_RISCV_NONSTANDARD_RELOC(QUALCOMM, R_RISCV_QC_E_JUMP_PLT, 195)
5 changes: 4 additions & 1 deletion llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,12 @@ std::optional<MCFixupKind> RISCVAsmBackend::getFixupKind(StringRef Name) const {
if (STI.getTargetTriple().isOSBinFormatELF()) {
unsigned Type;
Type = llvm::StringSwitch<unsigned>(Name)
#define ELF_RELOC(X, Y) .Case(#X, Y)
#define ELF_RELOC(NAME, ID) .Case(#NAME, ID)
#include "llvm/BinaryFormat/ELFRelocs/RISCV.def"
#undef ELF_RELOC
#define ELF_RISCV_NONSTANDARD_RELOC(_VENDOR, NAME, ID) .Case(#NAME, ID)
#include "llvm/BinaryFormat/ELFRelocs/RISCV_nonstandard.def"
#undef ELF_RISCV_NONSTANDARD_RELOC
.Case("BFD_RELOC_NONE", ELF::R_RISCV_NONE)
.Case("BFD_RELOC_32", ELF::R_RISCV_32)
.Case("BFD_RELOC_64", ELF::R_RISCV_64)
Expand Down
17 changes: 17 additions & 0 deletions llvm/test/MC/RISCV/custom_reloc.s
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,20 @@
nop
# CHECK-ASM: nop
# CHECK-OBJ: addi zero, zero, 0x0

.reloc ., R_RISCV_VENDOR, QUALCOMM
.reloc ., R_RISCV_QC_ABS20_U, my_bar + 2
addi a1, a1, 0
# CHECK-ASM: [[L3:.L[^:]+]]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ASM: line, shorter than the next line by 5, should be indented to align with the following lines

ditto below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

# CHECK-ASM-NEXT: .reloc [[L3]], R_RISCV_VENDOR, QUALCOMM
# CHECK-ASM-NEXT: [[L4:.L[^:]+]]:
# CHECK-ASM-NEXT: .reloc [[L4]], R_RISCV_QC_ABS20_U, my_bar+2
# CHECK-ASM-NEXT: mv a1, a1

# CHECK-OBJ: addi a1, a1, 0
# CHECK-OBJ-NEXT: R_RISCV_VENDOR QUALCOMM
# CHECK-OBJ-NEXT: R_RISCV_CUSTOM192 my_bar+0x2

nop
# CHECK-ASM: nop
# CHECK-OBJ: addi zero, zero, 0x0
Loading