Skip to content

[flang][cuda] Apply implicit data attribute only in device context #119919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[flang][cuda] Apply implicit data attribute only in device context #119919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flang/lib/Semantics/resolve-names.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8958,9 +8958,9 @@ void ResolveNamesVisitor::FinishSpecificationPart(
? currScope().symbol()->detailsIf<SubprogramDetails>()
: nullptr}) {
if (auto attrs{subp->cudaSubprogramAttrs()}) {
if (*attrs != common::CUDASubprogramAttrs::Device ||
*attrs != common::CUDASubprogramAttrs::Global ||
*attrs != common::CUDASubprogramAttrs::Grid_Global) {
if (*attrs == common::CUDASubprogramAttrs::Device ||
*attrs == common::CUDASubprogramAttrs::Global ||
*attrs == common::CUDASubprogramAttrs::Grid_Global) {
inDeviceSubprogram = true;
}
}
Expand Down
7 changes: 7 additions & 0 deletions flang/test/Semantics/modfile55.cuf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ module m
attributes(host,device) real function foo(x)
foo = x + 1.
end function
attributes(host) subroutine hostsub(a)
integer, intent(out) :: a(14)
a = 99
end subroutine
end

!Expect: m.mod
Expand All @@ -39,4 +43,7 @@ end
!real(4)::x
!real(4)::foo
!end
attributes(host)subroutinehostsub(a)
integer(4),intent(out)::a(1_8:14_8)
end
!end
Loading