Skip to content

[LLVM][SLSR] Add a debug counter #119981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 21, 2024
Merged

[LLVM][SLSR] Add a debug counter #119981

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9c2ca90
Added debug counter and new test
GrumpyPigSkin Dec 14, 2024
4c9ac9f
Implemented code review comments
GrumpyPigSkin Dec 17, 2024
04a37ff
Added new new line
GrumpyPigSkin Dec 17, 2024
9bf26df
Removed additional new line
GrumpyPigSkin Dec 17, 2024
8b5b159
Hopefully newline is now added
GrumpyPigSkin Dec 17, 2024
e66fca9
plz work
GrumpyPigSkin Dec 17, 2024
f548c76
Removed gvn pass from test
GrumpyPigSkin Dec 18, 2024
e58f65e
Moved debug counter to beginning of rewriteCandidateWithBasis
GrumpyPigSkin Dec 19, 2024
8bbfd69
Removed autoformatting error
GrumpyPigSkin Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion llvm/lib/Transforms/Scalar/StraightLineStrengthReduce.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
#include "llvm/InitializePasses.h"
#include "llvm/Pass.h"
#include "llvm/Support/Casting.h"
#include "llvm/Support/DebugCounter.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Transforms/Scalar.h"
#include "llvm/Transforms/Utils/Local.h"
Expand All @@ -93,6 +94,9 @@ using namespace PatternMatch;
static const unsigned UnknownAddressSpace =
std::numeric_limits<unsigned>::max();

DEBUG_COUNTER(StraightLineStrengthReduceCounter, "slsr-counter",
"Controls whether rewriteCandidateWithBasis is executed.");

namespace {

class StraightLineStrengthReduceLegacyPass : public FunctionPass {
Expand Down Expand Up @@ -690,7 +694,8 @@ bool StraightLineStrengthReduce::runOnFunction(Function &F) {
while (!Candidates.empty()) {
const Candidate &C = Candidates.back();
if (C.Basis != nullptr) {
rewriteCandidateWithBasis(C, *C.Basis);
if (DebugCounter::shouldExecute(StraightLineStrengthReduceCounter))
rewriteCandidateWithBasis(C, *C.Basis);
}
Candidates.pop_back();
}
Expand Down
30 changes: 30 additions & 0 deletions llvm/test/Other/debugcounter-slsr.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
; REQUIRES: asserts
; RUN: opt -passes=slsr,gvn -S -debug-counter=slsr-counter=1 < %s | FileCheck %s

;; Test that, with debug counters on, we will skip the first slsr opportunity.

define void @stride_is_2s(i32 %b, i32 %s) {
; CHECK-LABEL: @stride_is_2s(
; CHECK-NEXT: %s2 = shl i32 %s, 1
; CHECK-NEXT: %t1 = add i32 %b, %s2
; CHECK-NEXT: call void @foo(i32 %t1)
; CHECK-NEXT: %t2 = add i32 %t1, %s2
; CHECK-NEXT: call void @foo(i32 %t2)
; CHECK-NEXT: %s6 = mul i32 %s, 6
; CHECK-NEXT: %t3 = add i32 %b, %s6
; CHECK-NEXT: call void @foo(i32 %t3)
; CHECK-NEXT: ret void
;
%s2 = shl i32 %s, 1
%t1 = add i32 %b, %s2
call void @foo(i32 %t1)
%s4 = shl i32 %s, 2
%t2 = add i32 %b, %s4
call void @foo(i32 %t2)
%s6 = mul i32 %s, 6
%t3 = add i32 %b, %s6
call void @foo(i32 %t3)
ret void
}

declare void @foo(i32)
Loading