Skip to content

Port NVPTXTargetLowering::LowerCONCAT_VECTORS to SelectionDAG #120030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 27, 2025
+28 −1
Merged

Port NVPTXTargetLowering::LowerCONCAT_VECTORS to SelectionDAG #120030

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fbba746
first try
Esan5 Dec 16, 2024
34be657
fix tests
Esan5 Dec 17, 2024
22ecb84
comments
Esan5 Dec 17, 2024
2d1bfd7
prefer size 16 in small vector
Esan5 Dec 17, 2024
4e72483
trigger builds
Esan5 Dec 17, 2024
ade2707
comments
Esan5 Dec 18, 2024
5682483
extract to legal type
Esan5 Dec 20, 2024
1ac6bd5
use build through stack if type changes
Esan5 Dec 20, 2024
d184705
just checking if the type changed is not sufficient
Esan5 Dec 20, 2024
cef586a
use ExpandVectorBuildThroughStack if extract vector elt is not is not…
Esan5 Dec 21, 2024
cb1bfea
try ExpandConcatVectors if extract_vector_elt is not an Expand operation
Esan5 Jan 21, 2025
3c37765
remove braces negate and swap order
Esan5 Jan 23, 2025
f7c9f31
scalable vector guard with vector value type
Esan5 Jan 27, 2025
cb51c4e
remove dead code
Esan5 Mar 4, 2025
1effb91
Revert "remove dead code"
Esan5 Mar 5, 2025
c318b91
handled in a seperate PR
Esan5 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ class SelectionDAGLegalize {
SDValue ExpandExtractFromVectorThroughStack(SDValue Op);
SDValue ExpandInsertToVectorThroughStack(SDValue Op);
SDValue ExpandVectorBuildThroughStack(SDNode* Node);
SDValue ExpandConcatVectors(SDNode *Node);

SDValue ExpandConstantFP(ConstantFPSDNode *CFP, bool UseCP);
SDValue ExpandConstant(ConstantSDNode *CP);
Expand Down Expand Up @@ -1525,6 +1526,27 @@ SDValue SelectionDAGLegalize::ExpandInsertToVectorThroughStack(SDValue Op) {
BaseVecAlignment);
}

SDValue SelectionDAGLegalize::ExpandConcatVectors(SDNode *Node) {
assert(Node->getOpcode() == ISD::CONCAT_VECTORS && "Unexpected opcode!");
SDLoc DL(Node);
SmallVector<SDValue, 16> Ops;
unsigned NumOperands = Node->getNumOperands();
MVT VectorIdxType = TLI.getVectorIdxTy(DAG.getDataLayout());
EVT VectorValueType = Node->getOperand(0).getValueType();
unsigned NumSubElem = VectorValueType.getVectorNumElements();
EVT ElementValueType = TLI.getTypeToTransformTo(
*DAG.getContext(), VectorValueType.getVectorElementType());
for (unsigned I = 0; I < NumOperands; ++I) {
SDValue SubOp = Node->getOperand(I);
for (unsigned Idx = 0; Idx < NumSubElem; ++Idx) {
Ops.push_back(DAG.getNode(ISD::EXTRACT_VECTOR_ELT, DL, ElementValueType,
SubOp,
DAG.getConstant(Idx, DL, VectorIdxType)));
}
}
return DAG.getBuildVector(Node->getValueType(0), DL, Ops);
}

SDValue SelectionDAGLegalize::ExpandVectorBuildThroughStack(SDNode* Node) {
assert((Node->getOpcode() == ISD::BUILD_VECTOR ||
Node->getOpcode() == ISD::CONCAT_VECTORS) &&
Expand Down Expand Up @@ -3383,7 +3405,12 @@ bool SelectionDAGLegalize::ExpandNode(SDNode *Node) {
Results.push_back(ExpandInsertToVectorThroughStack(SDValue(Node, 0)));
break;
case ISD::CONCAT_VECTORS:
Results.push_back(ExpandVectorBuildThroughStack(Node));
if (EVT VectorValueType = Node->getOperand(0).getValueType();
VectorValueType.isScalableVector() ||
TLI.isOperationExpand(ISD::EXTRACT_VECTOR_ELT, VectorValueType))
Results.push_back(ExpandVectorBuildThroughStack(Node));
else
Results.push_back(ExpandConcatVectors(Node));
break;
case ISD::SCALAR_TO_VECTOR:
Results.push_back(ExpandSCALAR_TO_VECTOR(Node));
Expand Down