[NFC][Clang] Fix static analyzer concerns

[Fznamznon]

Remove unnecessary checks since they are checking that an unsigned number >= 0, which is always true.

[llvmbot]

@llvm/pr-subscribers-backend-amdgpu

Author: Mariya Podchishchaeva (Fznamznon)

Changes

Remove unnecessary checks since they are checking that an unsigned number >= 0, which is always true.

---

Full diff: https://github.com/llvm/llvm-project/pull/120259.diff

2 Files Affected:

• (modified) clang/lib/Basic/Targets/AMDGPU.h (-1)
• (modified) clang/lib/Basic/Targets/NVPTX.h (-1)

diff --git a/clang/lib/Basic/Targets/AMDGPU.h b/clang/lib/Basic/Targets/AMDGPU.h
index ea4189cdea47da..e3f0375315ad0c 100644
--- a/clang/lib/Basic/Targets/AMDGPU.h
+++ b/clang/lib/Basic/Targets/AMDGPU.h
@@ -119,7 +119,6 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo {
              (isTargetAddressSpace(A) &&
               toTargetAddressSpace(A) == llvm::AMDGPUAS::FLAT_ADDRESS)) &&
             isTargetAddressSpace(B) &&
-            toTargetAddressSpace(B) >= llvm::AMDGPUAS::FLAT_ADDRESS &&
             toTargetAddressSpace(B) <= llvm::AMDGPUAS::PRIVATE_ADDRESS &&
             toTargetAddressSpace(B) != llvm::AMDGPUAS::REGION_ADDRESS);
   }
diff --git a/clang/lib/Basic/Targets/NVPTX.h b/clang/lib/Basic/Targets/NVPTX.h
index d81b89a7f24ac0..b2f2447917e324 100644
--- a/clang/lib/Basic/Targets/NVPTX.h
+++ b/clang/lib/Basic/Targets/NVPTX.h
@@ -99,7 +99,6 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo {
               toTargetAddressSpace(A) ==
                   llvm::NVPTXAS::ADDRESS_SPACE_GENERIC)) &&
             isTargetAddressSpace(B) &&
-            toTargetAddressSpace(B) >= llvm::NVPTXAS::ADDRESS_SPACE_GENERIC &&
             toTargetAddressSpace(B) <= llvm::NVPTXAS::ADDRESS_SPACE_LOCAL &&
             toTargetAddressSpace(B) != 2);
   }

[llvmbot]

@llvm/pr-subscribers-clang

Author: Mariya Podchishchaeva (Fznamznon)

Changes

Remove unnecessary checks since they are checking that an unsigned number >= 0, which is always true.

---

Full diff: https://github.com/llvm/llvm-project/pull/120259.diff

2 Files Affected:

• (modified) clang/lib/Basic/Targets/AMDGPU.h (-1)
• (modified) clang/lib/Basic/Targets/NVPTX.h (-1)

diff --git a/clang/lib/Basic/Targets/AMDGPU.h b/clang/lib/Basic/Targets/AMDGPU.h
index ea4189cdea47da..e3f0375315ad0c 100644
--- a/clang/lib/Basic/Targets/AMDGPU.h
+++ b/clang/lib/Basic/Targets/AMDGPU.h
@@ -119,7 +119,6 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo {
              (isTargetAddressSpace(A) &&
               toTargetAddressSpace(A) == llvm::AMDGPUAS::FLAT_ADDRESS)) &&
             isTargetAddressSpace(B) &&
-            toTargetAddressSpace(B) >= llvm::AMDGPUAS::FLAT_ADDRESS &&
             toTargetAddressSpace(B) <= llvm::AMDGPUAS::PRIVATE_ADDRESS &&
             toTargetAddressSpace(B) != llvm::AMDGPUAS::REGION_ADDRESS);
   }
diff --git a/clang/lib/Basic/Targets/NVPTX.h b/clang/lib/Basic/Targets/NVPTX.h
index d81b89a7f24ac0..b2f2447917e324 100644
--- a/clang/lib/Basic/Targets/NVPTX.h
+++ b/clang/lib/Basic/Targets/NVPTX.h
@@ -99,7 +99,6 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo {
               toTargetAddressSpace(A) ==
                   llvm::NVPTXAS::ADDRESS_SPACE_GENERIC)) &&
             isTargetAddressSpace(B) &&
-            toTargetAddressSpace(B) >= llvm::NVPTXAS::ADDRESS_SPACE_GENERIC &&
             toTargetAddressSpace(B) <= llvm::NVPTXAS::ADDRESS_SPACE_LOCAL &&
             toTargetAddressSpace(B) != 2);
   }

[jhuber6]

I'm not sure, those enums might evaluate to zero but it makes it clearer and correct if they ever change. Realistically, the chance of that happening is pretty much zero, but still. I don't see this warning show up when I check with my LSP (though I do see some for else after return.)

[Fznamznon]

I'm not sure, those enums might evaluate to zero but it makes it clearer and correct if they ever change.

No problem, I had the same feeling. Just wanted to double check.