[llvm-exegesis] Fix warnings #120451
Closed
[llvm-exegesis] Fix warnings #120451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes: lib/Target/RISCV/RISCVGenAsmMatcher.inc:239:19: error: unused function 'MatchRegisterName' [-Werror,-Wunused-function] lib/Target/RISCV/RISCVGenAsmMatcher.inc:568:19: error: unused function 'MatchRegisterAltName' [-Werror,-Wunused-function]
Member
|
@llvm/pr-subscribers-tools-llvm-exegesis Author: Kazu Hirata (kazutakahirata) ChangesThis patch fixes: lib/Target/RISCV/RISCVGenAsmMatcher.inc:239:19: error: unused lib/Target/RISCV/RISCVGenAsmMatcher.inc:568:19: error: unused Full diff: https://github.com/llvm/llvm-project/pull/120451.diff 1 Files Affected:
diff --git a/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp b/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
index 891818b625fe14..41d361532908ca 100644
--- a/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
+++ b/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
@@ -135,9 +135,6 @@ ExegesisRISCVTarget::ExegesisRISCVTarget()
: ExegesisTarget(ArrayRef<CpuAndPfmCounters>{},
RISCV_MC::isOpcodeAvailable) {}
-#define GET_REGISTER_MATCHER
-#include "RISCVGenAsmMatcher.inc"
-
bool ExegesisRISCVTarget::matchesArch(Triple::ArchType Arch) const {
return Arch == Triple::riscv32 || Arch == Triple::riscv64;
}
|
boomanaiden154
approved these changes
Dec 18, 2024
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Contributor
Author
|
This will be part of the reland #120467. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes:
lib/Target/RISCV/RISCVGenAsmMatcher.inc:239:19: error: unused
function 'MatchRegisterName' [-Werror,-Wunused-function]
lib/Target/RISCV/RISCVGenAsmMatcher.inc:568:19: error: unused
function 'MatchRegisterAltName' [-Werror,-Wunused-function]