Skip to content

[LLVM] Update cmake maintainer #120542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2025
Merged

[LLVM] Update cmake maintainer #120542

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
277b660
[LLVM] Update cmake maintainer
nikic Dec 19, 2024
071cc73
Add chapuni for library layering
nikic Dec 20, 2024
acafdb7
Fix name order
nikic Dec 20, 2024
6dda0fe
Merge branch 'main' into cmake-maintainer
ldionne Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions llvm/Maintainers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,10 @@ [email protected] (email), [kuhar](https://github.com/kuhar) (GitHub)
Peter Collingbourne \
[email protected] (email), [pcc](https://github.com/pcc) (GitHub)

#### CMake and library layering
#### CMake

Chandler Carruth \
[email protected], chandlerc@google.com (email), [chandlerc](https://github.com/chandlerc) (GitHub)
Petr Hosek \
phosek@google.com (email), [petrhosek](https://github.com/petrhosek) (GitHub)
Copy link
Collaborator

@llvm-beanz llvm-beanz Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrhosek is a fantastic choice for CMake maintainer, but I actually think we probably need more than one maintainer for CMake. LLVM's CMake has really become extremely complex and varied, and there are a lot of changes that go into it (big and small).

I had started and never followed through on creating a set of code owners for CMake which at the time was @petrhosek, @compnerd, @smeenai, @ldionne, @tstellar, and myself. I'd probably add @MaskRay to that list too.

Copy link
Member

@petrhosek petrhosek Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we need more CMake maintainers. I'd also include @mstorsjo in your list.


#### Debug info

Expand All @@ -325,6 +325,11 @@ [email protected] (email), [d0k](https://github.com/d0k) (GitHub)
Teresa Johnson \
[email protected] (email), [teresajohnson](https://github.com/teresajohnson) (GitHub)

#### Library layering

Takumi Nakamura \
[email protected] (email), [chapuni](https://github.com/chapuni) (GitHub)

#### MCJIT, Orc, RuntimeDyld, PerfJITEvents

Lang Hames \
Expand Down Expand Up @@ -450,7 +455,7 @@ [email protected] (email), [lattner](https://github.com/lattner) (GitHub), clattn

Paul C. Anagnostopoulos ([email protected], [Paul-C-Anagnostopoulos](https://github.com/Paul-C-Anagnostopoulos)) -- TableGen \
Justin Bogner ([email protected], [bogner](https://github.com/bogner)) -- SelectionDAG \
Chandler Carruth ([email protected], [email protected], [chandlerc](https://github.com/chandlerc)) -- ADT, Support \
Chandler Carruth ([email protected], [email protected], [chandlerc](https://github.com/chandlerc)) -- ADT, Support, CMake and library layering \
Peter Collingbourne ([email protected], [pcc](https://github.com/pcc)) -- LTO \
Evan Cheng ([email protected]) -- Parts of code generator not covered by someone else \
Jake Ehrlich ([email protected], [jakehehrlich](https://github.com/jakehehrlich)) -- llvm-objcopy and ObjCopy library \
Expand Down
Loading