Skip to content

[SPIRV] Add support for cl_khr_extended_bit_ops #120571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 11, 2025
Merged

[SPIRV] Add support for cl_khr_extended_bit_ops #120571

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
95252e2
[SPIR-V] Add support for cl_khr_extended_bit_ops extension
maarquitos14 Nov 27, 2024
debfc1f
Change test from .ll file to .cl file.
maarquitos14 Dec 18, 2024
cc61409
Add __spirv_CODE wrappers for extended bit instructions.
maarquitos14 Dec 18, 2024
8a11b97
Undo changes on higher level directory LIT config.
maarquitos14 Dec 19, 2024
54128bb
Fix clang-format issues.
maarquitos14 Dec 19, 2024
c3fe999
Address code review feedback.
maarquitos14 Dec 20, 2024
c8b26ea
Add tests for SPIRV-friendly builtins.
maarquitos14 Jan 24, 2025
936cea7
Fix SPIRV-friendly builtins.
maarquitos14 Jan 24, 2025
aa2fd7a
Add new tests to check enabled capabilities.
maarquitos14 Jan 24, 2025
775d4ea
Update test.
maarquitos14 Jan 24, 2025
ab0ef11
Spin off SPIRV-friendly builtins test.
maarquitos14 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_bit_instructions/cl_khr_extended_bit_ops.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2743,9 +2743,90 @@ entry:

declare spir_func <16 x i8> @_Z11bit_reverseDv16_h(<16 x i8> noundef)

; Test SPIRV-friendly builtins.
Copy link
Contributor

@MrSidims MrSidims Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is worth to out separately from cl_khr_extended_bit_ops.ll

Copy link
Contributor Author

@maarquitos14 maarquitos14 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ab0ef11

; CHECK-EXTENSION: %[[#]] = OpFunction %[[#]] None %[[#]]
; CHECK-EXTENSION: %[[#insertbase_int2:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#insertinsert_int2:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#]] = OpBitFieldInsert %[[#]] %[[#insertbase_int2]] %[[#insertinsert_int2]]
; OpenCL equivalent.
; kernel void testInsert_SPIRVFriendly(int2 b, int2 i, global int2 *res) {
; *res = bitfield_insert(b, i, 4, 2);
; }
define spir_kernel void @testInsert_SPIRVFriendly(<2 x i32> %b, <2 x i32> %i, ptr addrspace(1) nocapture align 8 %res) #3 {
entry:
%call = call spir_func <2 x i32> @_Z22__spirv_BitFieldInsertDv2_iS_jj(<2 x i32> %b, <2 x i32> %i, i32 4, i32 2) #3
store <2 x i32> %call, ptr addrspace(1) %res, align 8
ret void
}

declare spir_func <2 x i32> @_Z22__spirv_BitFieldInsertDv2_iS_jj(<2 x i32>, <2 x i32>, i32, i32) #3


; CHECK-EXTENSION: %[[#]] = OpFunction %[[#]] None %[[#]]
; CHECK-EXTENSION: %[[#sextractbase:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#sextractbaseu:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#]] = OpBitFieldSExtract %[[#]] %[[#sextractbase]]
; CHECK-EXTENSION: %[[#]] = OpBitFieldSExtract %[[#]] %[[#sextractbaseu]]
; OpenCL equivalent.
; kernel void testExtractS_SPIRVFriendly(short b, ushort bu, global short *res) {
; *res = bitfield_extract_signed(b, 5, 4);
; *res += bitfield_extract_signed(bu, 5, 4);
; }
define spir_kernel void @testExtractS_SPIRVFriendly(i16 signext %b, i16 zeroext %bu, ptr addrspace(1) nocapture align 2 %res) #3 {
entry:
%call = call spir_func i16 @_Z24__spirv_BitFieldSExtractsjj(i16 %b, i32 5, i32 4) #3
%call1 = call spir_func i16 @_Z24__spirv_BitFieldSExtractsjj(i16 %bu, i32 5, i32 4) #3
%add = add i16 %call1, %call
store i16 %add, ptr addrspace(1) %res, align 2
ret void
}

declare spir_func i16 @_Z24__spirv_BitFieldSExtractsjj(i16, i32, i32) #3

; CHECK-EXTENSION: %[[#]] = OpFunction %[[#]] None %[[#]]
; CHECK-EXTENSION: %[[#uextractbase:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#uextractbaseu:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#]] = OpBitFieldUExtract %[[#]] %[[#uextractbase]]
; CHECK-EXTENSION: %[[#]] = OpBitFieldUExtract %[[#]] %[[#uextractbaseu]]
; OpenCL equivalent.
; kernel void testExtractU_SPIRVFriendly(char8 b, uchar8 bu, global uchar8 *res) {
; *res = bitfield_extract_unsigned(b, 3, 4);
; *res += bitfield_extract_unsigned(bu, 3, 4);
; }
define spir_kernel void @testExtractU_SPIRVFriendly(<8 x i8> %b, <8 x i8> %bu, ptr addrspace(1) nocapture align 8 %res) #3 {
entry:
%call = call spir_func <8 x i8> @_Z24__spirv_BitFieldUExtractDv8_hjj(<8 x i8> %b, i32 3, i32 4) #3
%call1 = call spir_func <8 x i8> @_Z24__spirv_BitFieldUExtractDv8_hjj(<8 x i8> %bu, i32 3, i32 4) #3
%add = add <8 x i8> %call1, %call
store <8 x i8> %add, ptr addrspace(1) %res, align 8
ret void
}

declare spir_func <8 x i8> @_Z24__spirv_BitFieldUExtractDv8_hjj(<8 x i8>, i32, i32) #3

; CHECK-EXTENSION: %[[#]] = OpFunction %[[#]] None %[[#]]
; CHECK-EXTENSION: %[[#reversebase:]] = OpFunctionParameter %[[#]]
; CHECK-EXTENSION: %[[#]] = OpBitReverse %[[#]] %[[#reversebase]]
; OpenCL equivalent.
; kernel void testBitReverse_SPIRVFriendly(long4 b, global long4 *res) {
; *res = bit_reverse(b);
; }
define spir_kernel void @testBitReverse_SPIRVFriendly(<4 x i64> %b, ptr addrspace(1) nocapture align 32 %res) #3 {
entry:
%call = call <4 x i64> @llvm.bitreverse.v4i64(<4 x i64> %b)
store <4 x i64> %call, ptr addrspace(1) %res, align 32
ret void
}

declare <4 x i64> @llvm.bitreverse.v4i64(<4 x i64>) #4



attributes #0 = { convergent mustprogress nofree norecurse nounwind willreturn memory(argmem: write) "no-trapping-math"="true" "stack-protector-buffer-size"="8" "uniform-work-group-size"="false" }
attributes #1 = { convergent mustprogress nofree nounwind willreturn memory(none) "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
attributes #2 = { convergent nounwind willreturn memory(none) }
attributes #3 = { nounwind }
attributes #4 = { nocallback nofree nosync nounwind speculatable willreturn memory(none) }

!llvm.module.flags = !{!0}
!opencl.ocl.version = !{!1}
Expand Down