Skip to content

[Hexagon] Only handle simple types memory accesses #120654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[Hexagon] Only handle simple types memory accesses #120654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/lib/Target/Hexagon/HexagonISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3793,6 +3793,8 @@ EVT HexagonTargetLowering::getOptimalMemOpType(
bool HexagonTargetLowering::allowsMemoryAccess(
LLVMContext &Context, const DataLayout &DL, EVT VT, unsigned AddrSpace,
Align Alignment, MachineMemOperand::Flags Flags, unsigned *Fast) const {
if (!VT.isSimple())
return false;
MVT SVT = VT.getSimpleVT();
if (Subtarget.isHVXVectorType(SVT, true))
return allowsHvxMemoryAccess(SVT, Flags, Fast);
Expand All @@ -3803,6 +3805,8 @@ bool HexagonTargetLowering::allowsMemoryAccess(
bool HexagonTargetLowering::allowsMisalignedMemoryAccesses(
EVT VT, unsigned AddrSpace, Align Alignment, MachineMemOperand::Flags Flags,
unsigned *Fast) const {
if (!VT.isSimple())
return false;
MVT SVT = VT.getSimpleVT();
if (Subtarget.isHVXVectorType(SVT, true))
return allowsHvxMisalignedMemoryAccesses(SVT, Flags, Fast);
Expand Down
22 changes: 22 additions & 0 deletions llvm/test/CodeGen/Hexagon/simple-types-mem.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
; RUN: llc -march=hexagon < %s
; REQUIRES: asserts

; Only simple types memory accesses are handled.

target triple = "hexagon"

%struct.hoge = type { i320 }

define dso_local void @widget() {
bb:
%tmp = alloca %struct.hoge, align 1
%tmp1 = bitcast %struct.hoge* %tmp to i320*
%tmp2 = load i320, i320* %tmp1, align 1
%tmp3 = and i320 %tmp2, -18446744073709551616
%tmp4 = or i320 %tmp3, 0
store i320 %tmp4, i320* %tmp1, align 1
call void @llvm.trap()
unreachable
}

declare void @llvm.trap()
Loading