Skip to content

[TableGen] Avoid repeated hash lookups (NFC) #120681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[TableGen] Avoid repeated hash lookups (NFC) #120681

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9dde9a
[TableGen] Avoid repeated hash lookups (NFC)
kazutakahirata Dec 19, 2024
cc47d4c
Address comments.
kazutakahirata Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3508,9 +3508,8 @@ void CodeGenDAGPatterns::FindPatternInputsAndOutputs(
Val->getDef()->isSubClassOf("PointerLikeRegClass")) {
if (Dest->getName().empty())
I.error("set destination must have a name!");
if (InstResults.count(Dest->getName()))
if (!InstResults.try_emplace(Dest->getName(), Dest).second)
I.error("cannot set '" + Dest->getName() + "' multiple times");
InstResults[Dest->getName()] = Dest;
} else if (Val->getDef()->isSubClassOf("Register")) {
InstImpResults.push_back(Val->getDef());
} else {
Expand Down
Loading