Skip to content

[MachinePipeliner] Skip reserved registers when computing register pressure #120694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[MachinePipeliner] Skip reserved registers when computing register pressure #120694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions llvm/lib/CodeGen/MachinePipeliner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,9 +1283,9 @@ class HighRegisterPressureDetector {
}
}

// Return true if Reg is fixed one, for example, stack pointer
bool isFixedRegister(Register Reg) const {
return Reg.isPhysical() && TRI->isFixedRegister(MF, Reg.asMCReg());
// Return true if Reg is reserved one, for example, stack pointer
bool isReservedRegister(Register Reg) const {
return Reg.isPhysical() && MRI.isReserved(Reg.asMCReg());
}

bool isDefinedInThisLoop(Register Reg) const {
Expand All @@ -1311,7 +1311,7 @@ class HighRegisterPressureDetector {
// because it's used only at the first iteration.
if (MI.isPHI() && Reg != getLoopPhiReg(MI, OrigMBB))
continue;
if (isFixedRegister(Reg))
if (isReservedRegister(Reg))
continue;
if (isDefinedInThisLoop(Reg))
continue;
Expand Down Expand Up @@ -1423,7 +1423,7 @@ class HighRegisterPressureDetector {

const auto InsertReg = [this, &CurSetPressure](RegSetTy &RegSet,
Register Reg) {
if (!Reg.isValid() || isFixedRegister(Reg))
if (!Reg.isValid() || isReservedRegister(Reg))
return;

bool Inserted = RegSet.insert(Reg).second;
Expand All @@ -1437,7 +1437,7 @@ class HighRegisterPressureDetector {

const auto EraseReg = [this, &CurSetPressure](RegSetTy &RegSet,
Register Reg) {
if (!Reg.isValid() || isFixedRegister(Reg))
if (!Reg.isValid() || isReservedRegister(Reg))
return;

// live-in register
Expand Down
Loading