Skip to content

[NFC] llvm-cgdata use StringRef in exitWithError to reduce construction #120771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[NFC] llvm-cgdata use StringRef in exitWithError to reduce construction #120771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions llvm/tools/llvm-cgdata/llvm-cgdata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ static CGDataAction Action;
static std::optional<CGDataFormat> OutputFormat;
static std::vector<std::string> InputFilenames;

static void exitWithError(Twine Message, std::string Whence = "",
std::string Hint = "") {
static void exitWithError(Twine Message, StringRef Whence = "",
StringRef Hint = "") {
WithColor::error();
if (!Whence.empty())
errs() << Whence << ": ";
Expand All @@ -97,16 +97,16 @@ static void exitWithError(Twine Message, std::string Whence = "",
static void exitWithError(Error E, StringRef Whence = "") {
if (E.isA<CGDataError>()) {
handleAllErrors(std::move(E), [&](const CGDataError &IPE) {
exitWithError(IPE.message(), std::string(Whence));
exitWithError(IPE.message(), Whence);
});
return;
}

exitWithError(toString(std::move(E)), std::string(Whence));
exitWithError(toString(std::move(E)), Whence);
}

static void exitWithErrorCode(std::error_code EC, StringRef Whence = "") {
exitWithError(EC.message(), std::string(Whence));
exitWithError(EC.message(), Whence);
}

static int convert_main(int argc, const char *argv[]) {
Expand Down
Loading