[AMDGPU] Support dynamically sized allocas #121047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
changed the title
easyonaadit
force-pushed
the
support-dynamically-sized-allocas
branch
from
93c0a23 to
f4001d4
Compare
easyonaadit
force-pushed
the
support-dynamically-sized-allocas
branch
2 times, most recently
from
435d293 to
6046b57
Compare
Currently, AMDGPU backend supports static sized allocas. This patch extends support for truly dynamic sized allocas. The value representing dynamic alloca size can be divergent which needs a wave-wide reduction to get the stack space. @llvm.amdgcn.wave.reduce.umax is used to perform the wave reduction. Note: Compiler already Zero-Extends or Truncates all other types(of alloca size arg) to i32.
easyonaadit
force-pushed
the
support-dynamically-sized-allocas
branch
from
6046b57 to
37dcbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, AMDGPU backend supports static sized allocas.
This patch extends support for truly dynamic sized allocas.
The value representing dynamic alloca size can be divergent
which needs a wave-wide reduction to get the stack space.
@llvm.amdgcn.wave.reduce.umaxis used to perform thewave reduction.
Note: Compiler already Zero-Extends or Truncates all other
types(of alloca size arg) to i32.