[Clang] fix for heterogeneous chip's host side's MaybeODRUseExprs clear

[fuaq]

For heterogeneous ai chip, if we choose host-side compilation there maybe missing for MaybeODRUseExprs's clear.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-clang

Author: None (fuaq)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/121085.diff

1 Files Affected:

• (modified) clang/lib/Sema/SemaStmtAsm.cpp (+6)

diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/SemaStmtAsm.cpp
index a0b203fbdfec21..5ff11fac9ca5f7 100644
--- a/clang/lib/Sema/SemaStmtAsm.cpp
+++ b/clang/lib/Sema/SemaStmtAsm.cpp
@@ -240,6 +240,12 @@ StmtResult Sema::ActOnGCCAsmStmt(SourceLocation AsmLoc, bool IsSimple,
                                  Expr *asmString, MultiExprArg clobbers,
                                  unsigned NumLabels,
                                  SourceLocation RParenLoc) {
+  struct _Cleaner {
+    Sema &S;
+    ~_Cleaner() {
+      S.DiscardCleanupsInEvaluationContext();
+    }
+  } _C{*this};
   unsigned NumClobbers = clobbers.size();
   StringLiteral **Constraints =
     reinterpret_cast<StringLiteral**>(constraints.data());

[fuaq]

@MaskRay
Can you help review it

[fuaq]

@ahatanak
Thank you for your commit 8fc33d71.
For heterogeneous ai chip, if we choose host-side compilation there maybe missing for MaybeODRUseExprs's clear.
Can you help review it.

[shafik]

I don't think I understand this change. There at least needs to be a more detailed summary and tests. I imagine test would help clarify the intent better.

[fuaq]

I don't think I understand this change. There at least needs to be a more detailed summary and tests. I imagine test would help clarify the intent better.

hi, It will lead to a crash for this test without this pr.just like this

[fuaq]

@shafik Added test for this bug. For heterogeneous chip's host side compilation, just like