[mlir][arith] DCE getPredicateByName

[makslevental]

This is dead code (no impls or uses anywhere in the code base) that causes linker errors in some build configurations.

[llvmbot]

@llvm/pr-subscribers-mlir-arith

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

Changes

This is dead code (no impls or uses anywhere in the code base) that causes linker errors in some build configurations.

---

Full diff: https://github.com/llvm/llvm-project/pull/121165.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/Arith/IR/ArithOps.td (-8)

diff --git a/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td b/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
index 2f71caaa593a6c..0722ff68d890de 100644
--- a/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
+++ b/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
@@ -1499,10 +1499,6 @@ def Arith_CmpIOp
                        SignlessIntegerLikeOfAnyRank:$lhs,
                        SignlessIntegerLikeOfAnyRank:$rhs);
 
-  let extraClassDeclaration = [{
-    static arith::CmpIPredicate getPredicateByName(StringRef name);
-  }];
-
   let hasFolder = 1;
   let hasCanonicalizer = 1;
 }
@@ -1546,10 +1542,6 @@ def Arith_CmpFOp : Arith_CompareOp<"cmpf",
                        DefaultValuedAttr<
                          Arith_FastMathAttr, "::mlir::arith::FastMathFlags::none">:$fastmath);
 
-  let extraClassDeclaration = [{
-    static arith::CmpFPredicate getPredicateByName(StringRef name);
-  }];
-
   let hasFolder = 1;
   let hasCanonicalizer = 1;
   let assemblyFormat = [{ $predicate `,` $lhs `,` $rhs (`fastmath` `` $fastmath^)?

[Groverkss]

LGTM, probably a debug function, but it shouldnt be part of the operation's definition even if so.

[ftynse]

I think this was rather a remnant of the old parsing strategy where we parsed the predicate as a string attribute before converting.