Skip to content

[mlir][Transforms] Dialect conversion: add missing argument materialization. #121200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[mlir][Transforms] Dialect conversion: add missing argument materialization. #121200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions mlir/lib/Transforms/Utils/DialectConversion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,12 +1375,18 @@ Block *ConversionPatternRewriterImpl::applySignatureConversion(
// used as a replacement.
auto replArgs =
newBlock->getArguments().slice(inputMap->inputNo, inputMap->size);
auto insertPoint = OpBuilder::InsertPoint(newBlock, newBlock->begin());
if (replArgs.size() == 1) {
mapping.map(origArg, replArgs.front());
// We need an argument materialization to replace the block argument.
Value argMat = buildUnresolvedMaterialization(
Copy link
Member

@matthias-springer matthias-springer Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary. Argument materialization are a workaround around missing 1:N support, but this is a 1:1 replacement.

MaterializationKind::Argument, insertPoint, origArg.getLoc(),
/*valueToMap=*/origArg, /*inputs=*/replArgs,
/*outputType=*/origArg.getType(), /*originalType=*/Type(), converter);
mapping.map(origArg, argMat);
} else {
insertNTo1Materialization(
OpBuilder::InsertPoint(newBlock, newBlock->begin()), origArg.getLoc(),
/*replacements=*/replArgs, /*outputValue=*/origArg, converter);
insertNTo1Materialization(insertPoint, origArg.getLoc(),
/*replacements=*/replArgs,
/*originalValue=*/origArg, converter);
}
appendRewrite<ReplaceBlockArgRewrite>(block, origArg, converter);
}
Expand Down
Loading