[GlobalISel] Catching inconsistencies in load memory, result, and range metadata type

llvm/lib/CodeGen/MachineVerifier.cpp

@@ -1274,6 +1274,24 @@ void MachineVerifier::verifyPreISelGenericInstruction(const MachineInstr *MI) {
         if (TypeSize::isKnownGT(MMO.getSize().getValue(),
                                 ValTy.getSizeInBytes()))
           report("load memory size cannot exceed result size", MI);
+
+        if (MMO.getRanges()) {
+          auto operandBits = [](const MDOperand &o) -> unsigned {
+            ConstantInt *i = mdconst::dyn_extract<ConstantInt>(o);
+            if (!i->isNegative())
+              return i->getValue().getActiveBits();
+            APInt reversed(i->getValue());
+            reversed.negate();
+            return reversed.getActiveBits() + 1; // one more bit for the sign
+          };
+          unsigned bitsUsed =
+              std::max(operandBits(MMO.getRanges()->getOperand(0)),
+                       operandBits(MMO.getRanges()->getOperand(1)));
+          if (bitsUsed != ValTy.getScalarType().getSizeInBits()) {
+            report("range is incompatible with the value it gets assigned to",
+                   MI);
+          }
+        }
       } else if (MI->getOpcode() == TargetOpcode::G_STORE) {
         if (TypeSize::isKnownLT(ValTy.getSizeInBytes(),
                                 MMO.getSize().getValue()))

llvm/test/MachineVerifier/test_g_load_vector_to_scalar.mir

@@ -0,0 +1,72 @@
+# RUN: not --crash llc -mtriple=amdgcn-mesa-mesa3d -mcpu=tahiti -run-pass=none %s -o -
+--- |
+  define void @range_metadata_sext_i8_signed_range_i64_load_as_v2i32() {
+   ret void
+  }
+
+  define void @range_metadata_sext_i8_signed_range_i64_load_as_v2i32_extractlo() {
+   ret void
+  }
+
+  define void @range_metadata_sext_i33_signed_range_i64_load_as_v2i32() {
+    ret void
+  }
+
+  !0 = !{i64 -4294967295, i64 4294967296}
+  !1 = !{i64 -8589934591, i64 8589934592}
+
+...
+---
+name:            range_metadata_sext_i33_signed_range_i64_load_as_v2i32
+tracksRegLiveness: true
+body:             |
+  bb.0:
+    liveins: $vgpr0, $vgpr1
+
+    %1:_(s32) = COPY $vgpr0
+    %2:_(s32) = COPY $vgpr1
+    %0:_(p1) = G_MERGE_VALUES %1(s32), %2(s32)
+    ; CHECK: Bad machine code: range is incompatible with the value it gets assigned to
+    %3:_(<2 x s32>) = G_LOAD %0(p1) :: (volatile load (s64), align 4, !range !1, addrspace 1)
+    $vgpr0_vgpr1 = COPY %3
+    SI_RETURN implicit $vgpr0_vgpr1
+
+...
+
+---
+name:            range_metadata_sext_i8_signed_range_i64_load_as_v2i32_extractlo
+tracksRegLiveness: true
+body:             |
+  bb.0:
+    liveins: $vgpr0, $vgpr1
+
+    %1:_(s32) = COPY $vgpr0
+    %2:_(s32) = COPY $vgpr1
+    %0:_(p1) = G_MERGE_VALUES %1(s32), %2(s32)
+    ; CHECK: Bad machine code: range is incompatible with the value it gets assigned to
+    %3:_(<2 x s32>) = G_LOAD %0(p1) :: (volatile load (s64), align 4, !range !0, addrspace 1)
+    %zero:_(s32) = G_CONSTANT i32 0
+    %extract:_(s32) = G_EXTRACT_VECTOR_ELT %3, %zero
+    %6:_(s32) = G_SEXT_INREG %zero, 9
+    $vgpr0 = COPY %6
+    SI_RETURN implicit $vgpr0, implicit $vgpr1
+
+...
+
+---
+name:            range_metadata_sext_i8_signed_range_i64_load_as_v2i32
+tracksRegLiveness: true
+body:             |
+  bb.0:
+    liveins: $vgpr0, $vgpr1
+
+    %1:_(s32) = COPY $vgpr0
+    %2:_(s32) = COPY $vgpr1
+    %0:_(p1) = G_MERGE_VALUES %1(s32), %2(s32)
+    ; CHECK: Bad machine code: range is incompatible with the value it gets assigned to
+    %3:_(<2 x s32>) = G_LOAD %0(p1) :: (volatile load (s64), align 4, !range !0, addrspace 1)
+    %6:_(<2 x s32>) = G_SEXT_INREG %3, 9
+    $vgpr0_vgpr1 = COPY %6
+    SI_RETURN implicit $vgpr0_vgpr1
+
+...