Skip to content

Conversation

@JonPsson1
Copy link
Contributor

@JonPsson1 JonPsson1 commented Jan 2, 2025

The NoExt attribute was introduced with #100757, to exist alongside with signext and zeroext.

Add "noext" as an attribute to llvm-mode.el to get the proper highlighting of the keyword.

(For test case using this attribute, see for example llvm/test/CodeGen/SystemZ/args-14.ll)

@goldsteinn @lukel97

@goldsteinn
Copy link
Contributor

goldsteinn commented Jan 2, 2025

LGTM

let me know if you need me to merge for you.

@JonPsson1 JonPsson1 merged commit 8ab88f1 into llvm:main Jan 2, 2025
9 checks passed
@JonPsson1 JonPsson1 deleted the Emacs branch January 2, 2025 16:03
@JonPsson1
Copy link
Contributor Author

Thanks.

I tried to merge it here, but I got a mail:

"LLVM Premerge Checks: All jobs have failed"
https://github.com/llvm/llvm-project/actions/runs/12585196983
@goldsteinn

@goldsteinn
Copy link
Contributor

Thanks.

I tried to merge it here, but I got a mail:

"LLVM Premerge Checks: All jobs have failed" https://github.com/llvm/llvm-project/actions/runs/12585196983 @goldsteinn

Don't worry about that. Change is in and I don't see it get reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants