Skip to content

[RISCV][TTI] Simplify compound check for readability [nfc] #121504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2025
Merged

[RISCV][TTI] Simplify compound check for readability [nfc] #121504

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
736f1d2
[RISCV][TTI] Simplify compound check for readability [nfc]
preames Jan 2, 2025
645bfec
Address review comment
preames Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2558,8 +2558,10 @@ RISCVTTIImpl::enableMemCmpExpansion(bool OptSize, bool IsZeroCmp) const {
TTI::MemCmpExpansionOptions Options;
// TODO: Enable expansion when unaligned access is not supported after we fix
// issues in ExpandMemcmp.
if (!(ST->enableUnalignedScalarMem() &&
(ST->hasStdExtZbb() || ST->hasStdExtZbkb() || IsZeroCmp)))
if (!ST->enableUnalignedScalarMem())
return Options;

if (!(ST->hasStdExtZbb() || ST->hasStdExtZbkb() || IsZeroCmp))
Copy link
Collaborator

@topperc topperc Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deMorgan this?

return Options;

Options.AllowOverlappingLoads = true;
Expand Down
Loading