Skip to content

[mlir][python] declare _PyClassMethod_New undefined at link time #121597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 3, 2025
Merged

[mlir][python] declare _PyClassMethod_New undefined at link time #121597

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba6ee7b
Update AddMLIRPython.cmake
makslevental Jan 3, 2025
97216a6
Update mlir/cmake/modules/AddMLIRPython.cmake
makslevental Jan 3, 2025
b84454c
Update AddMLIRPython.cmake
makslevental Jan 3, 2025
f3158d2
Update mlir/cmake/modules/AddMLIRPython.cmake
makslevental Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mlir/cmake/modules/AddMLIRPython.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,12 @@ function(add_mlir_python_extension libname extname)
endif()

target_compile_options(${libname} PRIVATE ${eh_rtti_enable})
if(APPLE)
# NanobindAdaptors.h uses PyClassMethod_New to build `pure_subclass`es but nanobind
# doesn't declare this API as undefined in its linker flags. so we need to declare it as such
# for downstream users that do not do something like -undefined dynamic_lookup
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-U -Wl,_PyClassMethod_New")
endif()

# Configure the output to match python expectations.
set_target_properties(
Expand Down
Loading