[NFC][flang] Add missing dependency for shared builds #121617
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FortranEvaluate is required for Fortran::lower::genImplicitBoundsOps
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Evgenii Kudriashov (e-kud) ChangesFortranEvaluate is required for Fortran::lower::genImplicitBoundsOps Full diff: https://github.com/llvm/llvm-project/pull/121617.diff 1 Files Affected:
diff --git a/flang/lib/Optimizer/OpenMP/CMakeLists.txt b/flang/lib/Optimizer/OpenMP/CMakeLists.txt
index 4f23b2b970fa44..026889cca238a0 100644
--- a/flang/lib/Optimizer/OpenMP/CMakeLists.txt
+++ b/flang/lib/Optimizer/OpenMP/CMakeLists.txt
@@ -22,6 +22,7 @@ add_flang_library(FlangOpenMPTransforms
FIRDialectSupport
FIRSupport
FortranCommon
+ FortranEvaluate
MLIRFuncDialect
MLIROpenMPDialect
HLFIRDialect
|
Contributor
|
FYI: #121370 It is okay if you merge this one. |
Contributor
Author
|
@vzakhari oh, sorry, I don't really track flang activity. I've noticed that this issue is still actual for a long time. I'll close this one as it's the later one. |
Contributor
|
No problem at all! I merged the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FortranEvaluate is required for Fortran::lower::genImplicitBoundsOps