[Fixes] Added option to readability-implicit-bool-conversion check to allow implicit conversion *to bool* #121761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new options in ImplicitBoolConversionCheck CheckConversionToBool and CheckConversionFromBool.
Added CheckConversionToBool and CheckConversionFromBool Options in the header
Added new test to check the new options added in the ImplicitBoolConversionCheck.cpp
Fixed Bugs
Fixed Bugs in test .
Added new Options in ImplicitBoolConversionCheck.
Improved Preview By adding blank line.
Fixed Bugs .
Fixed Bugs .
Fixed Bugs.
Formatted using clang-format.
Fixed Some Bugs.
Documented the new options.
Rewritten the RUN directives.
Fixed by separating options by ',' .
Fixed Bugs regarding wrong variable names.
Fixed Bugs regarding mismatched named variables.
Improved Readibility and Description.
Fixed Bugs related to check-suffix.
Just for testing purpose of BuildKite.
Wrote basic level tests. (Similar to the tests in other check files).
Updated for all permutations of configurations options and also for the more comprehensive tests.
FIxed Clang formatting issue.
|
|
Sh0g0-1758
requested review from
5chmidti,
HerrCai0907 and
PiotrZSL
and removed request for
5chmidti,
HerrCai0907 and
PiotrZSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is for fixing the failed build-bot checks for the PR(#120087) which references issue (#36323)