[HLSL] Fix build warning after #116331 #121852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) ChangesAfter #116331 is always SpellingNotCalculated, Full diff: https://github.com/llvm/llvm-project/pull/121852.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp b/clang/lib/CodeGen/CodeGenFunction.cpp
index 56c56f564fd09d..067ff55b87ae63 100644
--- a/clang/lib/CodeGen/CodeGenFunction.cpp
+++ b/clang/lib/CodeGen/CodeGenFunction.cpp
@@ -2102,7 +2102,10 @@ void CodeGenFunction::EmitBranchOnBoolExpr(
MDHelper.createConstant(BranchHintConstant)});
BrInst->setMetadata("hlsl.controlflow.hint",
llvm::MDNode::get(CGM.getLLVMContext(), Vals));
- } break;
+ break;
+ }
+ case HLSLControlFlowHintAttr::SpellingNotCalculated:
+ break;
}
}
|
joaosaffran
approved these changes
Jan 6, 2025
Contributor
joaosaffran
left a comment
joaosaffran
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this
vitalybuka
deleted the
users/vitalybuka/spr/hlsl-fix-build-warning-after-116331
branch
llvm-beanz
added a commit
to llvm-beanz/llvm-project
that referenced
this pull request
Jan 8, 2025
This reverts commit 1a435fe.
llvm-beanz
added a commit
that referenced
this pull request
Jan 8, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Jan 8, 2025
This reverts commit b66f6b2.
joaosaffran
added a commit
that referenced
this pull request
Jan 13, 2025
- Adding the changes from PRs: - #116331 - #121852 - Fixes test `tools/dxil-dis/debug-info.ll` - Address some missed comments in the previous PR --------- Co-authored-by: joaosaffran <[email protected]>
kazutakahirata
pushed a commit
to kazutakahirata/llvm-project
that referenced
this pull request
Jan 13, 2025
…122157) - Adding the changes from PRs: - llvm#116331 - llvm#121852 - Fixes test `tools/dxil-dis/debug-info.ll` - Address some missed comments in the previous PR --------- Co-authored-by: joaosaffran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #116331 is always SpellingNotCalculated,
so I assume doing nothing is expected.