[lldb][Posix] Remove unused includes in file system #121913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could remove unistd.h and it builds, but only because something else included it. So I've left it in in the spirit of "include what you use".
Member
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesYou could remove unistd.h and it builds, but only because something else included it. So I've left it in in the spirit of "include what you use". Tested on Linux and FreeBSD. Full diff: https://github.com/llvm/llvm-project/pull/121913.diff 1 Files Affected:
diff --git a/lldb/source/Host/posix/FileSystemPosix.cpp b/lldb/source/Host/posix/FileSystemPosix.cpp
index 945e2affc83715..d2e5b52917ac26 100644
--- a/lldb/source/Host/posix/FileSystemPosix.cpp
+++ b/lldb/source/Host/posix/FileSystemPosix.cpp
@@ -9,12 +9,7 @@
#include "lldb/Host/FileSystem.h"
// C includes
-#include <dirent.h>
#include <fcntl.h>
-#include <sys/mount.h>
-#include <sys/param.h>
-#include <sys/stat.h>
-#include <sys/types.h>
#include <unistd.h>
#if defined(__NetBSD__)
#include <sys/statvfs.h>
|
labath
approved these changes
Jan 7, 2025
Member
DhruvSrivastavaX
left a comment
DhruvSrivastavaX
left a comment
There was a problem hiding this comment.
Tested with AIX too. Thanks!
Contributor
|
@DavidSpickett The NetBSD statvfs header can be removed as the relevant code was removed quite some time ago.. bfe8bcb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could remove unistd.h and it will still build, but only because something else included it. So I've left it in in the spirit of "include what you use".
Tested on Linux and FreeBSD.