Skip to content

[UpdateTestChecks][NFC] - Fix typos #121964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[UpdateTestChecks][NFC] - Fix typos #121964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions llvm/test/tools/UpdateTestChecks/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ except ImportError:
from pipes import quote as shell_quote


def add_update_script_substition(
def add_update_script_substitution(
name, python_exe=config.python_executable, extra_args=""
):
assert name.startswith("%")
Expand All @@ -33,26 +33,26 @@ llc_path = os.path.join(config.llvm_tools_dir, "llc")
if os.path.isfile(llc_path):
config.available_features.add("llc-binary")
llc_arg = "--llc-binary " + shell_quote(llc_path)
add_update_script_substition("%update_llc_test_checks", extra_args=llc_arg)
add_update_script_substition("%update_mir_test_checks", extra_args=llc_arg)
add_update_script_substitution("%update_llc_test_checks", extra_args=llc_arg)
add_update_script_substitution("%update_mir_test_checks", extra_args=llc_arg)

opt_path = os.path.join(config.llvm_tools_dir, "opt")
if os.path.isfile(opt_path):
config.available_features.add("opt-binary")
opt_arg = "--opt-binary " + shell_quote(opt_path)
add_update_script_substition("%update_test_checks", extra_args=opt_arg)
add_update_script_substition("%update_analyze_test_checks", extra_args=opt_arg)
add_update_script_substitution("%update_test_checks", extra_args=opt_arg)
add_update_script_substitution("%update_analyze_test_checks", extra_args=opt_arg)

llvm_mca_path = os.path.join(config.llvm_tools_dir, "llvm-mca")
if os.path.isfile(llvm_mca_path):
config.available_features.add("llvm-mca-binary")
mca_arg = "--llvm-mca-binary " + shell_quote(llvm_mca_path)
add_update_script_substition("%update_test_checks", extra_args=mca_arg)
add_update_script_substitution("%update_test_checks", extra_args=mca_arg)

split_file_path = os.path.join(config.llvm_tools_dir, "split-file")
if os.path.isfile(split_file_path):
add_update_script_substition("%update_test_body")
add_update_script_substitution("%update_test_body")

llvm_mc_path = os.path.join(config.llvm_tools_dir, "llvm-mc")
if os.path.isfile(llvm_mc_path):
add_update_script_substition("%update_mc_test_checks")
add_update_script_substitution("%update_mc_test_checks")
2 changes: 1 addition & 1 deletion llvm/utils/UpdateTestChecks/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,7 @@ def find_diff_matching(lhs: List[str], rhs: List[str]) -> List[tuple]:
backlinks.append(None)

# Commit to names in the matching by walking the backlinks. Recursively
# attempt to fill in more matches in-betweem.
# attempt to fill in more matches in-between.
match_idx = table_candidate_idx[-1]
while match_idx is not None:
current = candidates[match_idx]
Expand Down
Loading