Skip to content

Boundary condition check hidden under assert #122009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Boundary condition check hidden under assert #122009

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a0b215a
[Nomination] Add additional Apple representative to the Security Group
AbhayKanhere Dec 4, 2024
e1e802b
Merge branch 'llvm:main' into main
AbhayKanhere Dec 4, 2024
4a21a65
Merge branch 'llvm:main' into main
AbhayKanhere Dec 5, 2024
57fd7fe
Merge branch 'llvm:main' into main
AbhayKanhere Jan 7, 2025
38e3bd0
Merge branch 'llvm:main' into main
AbhayKanhere Jan 7, 2025
954777f
[CodeGen][DebugValues] Fix unhandled error condition in VarLoc
AbhayKanhere Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,13 +997,6 @@ class VarLocBasedLDV : public LDVImpl {
return *VLS;
}

const VarLocSet &getVarLocsInMBB(const MachineBasicBlock *MBB,
const VarLocInMBB &Locs) const {
auto It = Locs.find(MBB);
assert(It != Locs.end() && "MBB not in map");
return *It->second;
}

/// Tests whether this instruction is a spill to a stack location.
bool isSpillInstruction(const MachineInstr &MI, MachineFunction *MF);

Expand Down Expand Up @@ -1286,7 +1279,10 @@ void VarLocBasedLDV::printVarLocInMBB(const MachineFunction &MF,
for (const MachineBasicBlock &BB : MF) {
if (!V.count(&BB))
continue;
const VarLocSet &L = getVarLocsInMBB(&BB, V);
auto It = V.find(&BB);
if (It == V.end())
continue;
const VarLocSet &L = *It->second;
if (L.empty())
continue;
SmallVector<VarLoc, 32> VarLocs;
Expand Down
Loading