llvm-jitlink fixes #122067
Closed
llvm-jitlink fixes #122067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures cleanup of task dispatcher threads. This may address some of the nondeterministic failures seen in llvm-jitlink regression tests recently.
Dispatcher shutdown must ensure that any dispatched Tasks have completed *and been destroyed* prior to returning, so that the ExecutionSession (which Tasks may access) can be safely destroyed. DynamicThreadPoolTaskDispatcher::dispatch was holding a unique pointer to the most recent Task past the point where it notified the shutdown method (via OutstandingCV) that the thread was done. This could lead to the ExecutionSession being destroyed before the Task, resulting in use-after-free style errors (e.g. assertions about dangling SymbolStringPtrs in the SymbolStringPool destructor). The solution is just to destroy the Task object immediately after running it. This patch also updates the dispatch method to reject any Task dispatched after the shutdown flag is raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.